Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Nov 21, 2025

Refs #14280

I think, the issue is right. Somehow the class Formatter was not moved.

This only applies the refactorings of IntelliJ. No other change.

Steps to test

One could check with https://github.com/tsantalis/RefactoringMiner for correctness.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Nov 21, 2025
@koppor
Copy link
Member Author

koppor commented Nov 21, 2025

Funny JBang output - some package renaming did not get through somewhere...

Can be ignored.

Error: Exception in thread "main" java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    org/jabref/logic/importer/util/MetaDataParser.<clinit>()V @31: invokespecial
  Reason:
    Type 'org/jabref/logic/formatter/bibtexfields/NormalizePagesFormatter' (current frame, stack[3]) is not assignable to 'org/jabref/logic/cleanup/Formatter'
  Current Frame:
    bci: @31
    flags: { }
    locals: { }
    stack: { uninitialized 17, uninitialized 17, 'org/jabref/model/entry/field/StandardField', 'org/jabref/logic/formatter/bibtexfields/NormalizePagesFormatter' }
  Bytecode:
    0000000: 1208 b801 ccb3 004c 1301 d2b8 01d4 b301
    0000010: 4ebb 01d8 59b2 01da bb01 e059 b701 e2b7
    0000020: 01e3 bb01 d859 b201 e6bb 01e9 59b7 01eb
    0000030: b701 e3bb 01d8 59b2 01ec bb01 ef59 b701
    0000040: f1b7 01e3 bb01 d859 b201 f2bb 01f8 59b7
    0000050: 01fa b701 e3b8 01fb b301 abb1          

	at org.jabref.logic.importer.fileformat.BibtexParser.<init>(BibtexParser.java:120)
	at org.jabref.logic.importer.fileformat.BibtexParser.<init>(BibtexParser.java:125)
	at org.jabref.logic.importer.fileformat.pdf.PdfEmbeddedBibFileImporter.<init>(PdfEmbeddedBibFileImporter.java:35)

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 21, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 22, 2025
Merged via the queue into main with commit b103c3b Nov 22, 2025
70 of 81 checks passed
@Siedlerchr Siedlerchr deleted the fix-package branch November 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants