-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Refactor formatter cleanup classes #14285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactor Formatter and FieldFormatterCleanups in package org.jabref.logic.cleanup. - Move Formatter to logic.formatter package, as base class of other formatters. - Rename FieldFormatterCleanups to FieldFormatterCleanupActions. - Abstract parsing logic to a new class named FieldFormatterCleanupParser.
|
Your code currently does not meet JabRef's code guidelines. IntelliJ auto format covers some cases. There seem to be issues with your code style and autoformat configuration. Please reformat your code (Ctrl+Alt+L) and commit, then push. In special cases, consider using |
|
@EricW123 Thank you for your contribution. Please fix the the issues discovered by the CI so that the code is proapred for human review. |
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| } | ||
|
|
||
| public static List<FieldFormatterCleanup> parse(String formatterString) { | ||
| if ((formatterString == null) || formatterString.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method is now a one-liner - maybe remove competely (if I read your issue correctly)
…-14280 # Conflicts: # jabgui/src/main/java/org/jabref/gui/cleanup/CleanupPresetPanel.java # jabgui/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java
|
@EricW123 I took the liberty to merge upstream and to fix merge conflicts. Should be easier to for you, if you want to pick this PR up again. |
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
Refactor Formatter and FieldFormatterCleanups in package org.jabref.logic.cleanup.
Closes #14280
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)