Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected entry in search window selects entry in the main table #11010

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Selected entry in search window selects entry in the main table #11010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
373a3b1
Selected entry in search window focuses library and selects item in m…
LoayGhreeb Mar 12, 2024
9ff2143
Update CHANGELOG.md
LoayGhreeb Mar 12, 2024
33a595c
Center the search window on the screen
LoayGhreeb Mar 12, 2024
49f0ac0
delete setCurrentTab method
LoayGhreeb Mar 13, 2024
b00c0fc
Merge branch 'main' into issue-9362
LoayGhreeb Mar 20, 2024
55e579c
Used equals instead of "=="
LoayGhreeb Mar 20, 2024
ee48a81
Update CHANGELOG.md
LoayGhreeb Mar 20, 2024
cd91bf2
Refactor method name
LoayGhreeb Mar 20, 2024
433982b
create only one instance of GlobalSearchResultDialog
LoayGhreeb Mar 20, 2024
0b8bbb5
Update CHANGELOG.md
LoayGhreeb Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/main/java/org/jabref/gui/JabRefFrame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,15 +631,6 @@ public LibraryTab getCurrentLibraryTab() {
return (LibraryTab) tabbedPane.getSelectionModel().getSelectedItem();
}

public void setCurrentTab(BibDatabaseContext databaseContext) {
for (LibraryTab libraryTab : getLibraryTabs()) {
if (libraryTab.getBibDatabaseContext() == databaseContext) {
tabbedPane.getSelectionModel().select(libraryTab);
return;
}
}
}

private ContextMenu createTabContextMenuFor(LibraryTab tab, KeyBindingRepository keyBindingRepository) {
ContextMenu contextMenu = new ContextMenu();
ActionFactory factory = new ActionFactory(keyBindingRepository);
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/org/jabref/gui/LibraryTabContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ public interface LibraryTabContainer {

void addTab(BibDatabaseContext bibDatabaseContext, boolean raisePanel);

void setCurrentTab(BibDatabaseContext bibDatabaseContext);

/**
* Closes a designated libraryTab
*
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ private void initialize() {
resultsTable.getSelectionModel().selectedItemProperty().addListener((obs, old, newValue) -> {
if (newValue != null) {
previewViewer.setEntry(newValue.getEntry());
libraryTabContainer.setCurrentTab(newValue.getBibDatabaseContext());
libraryTabContainer.getLibraryTabs().stream()
.filter(tab -> tab.getBibDatabaseContext() == newValue.getBibDatabaseContext())
LoayGhreeb marked this conversation as resolved.
Show resolved Hide resolved
.findFirst()
.ifPresent(libraryTabContainer::showLibraryTab);
stateManager.activeTabProperty().get().ifPresent(tab -> tab.clearAndSelect(newValue.getEntry()));
} else {
previewViewer.setEntry(old.getEntry());
Expand Down
Loading