-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selected entry in search window selects entry in the main table #11010
Conversation
I figured out two issues with the current implementation:
|
src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java
Outdated
Show resolved
Hide resolved
- Keywords filed are now displayed as tags. [#10910](https://github.com/JabRef/jabref/pull/10910) | ||
- Keywords field are now displayed as tags. [#10910](https://github.com/JabRef/jabref/pull/10910) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment: In future, try to separate these small side changes to other pull requests. Reason: If a PR takes long to review, these kind of changes will be "outdated" (e.g., causing conflicts, because other PRs also touch these places).
On Linux (and Mac) you can try GitButler for "carving out" unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closes #9362
preview.mp4
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)