Pull request for solving Issue #18 : Rename "markers" which hides the field declared at line 93 [ChartView.java:806] #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming local variable, markers, to xAxisMarkers to not be confused with class level variable with same name.
|
Avilad0
pushed a commit
that referenced
this pull request
Feb 17, 2024
Rename variable to match naming convention. Closes #19
Avilad0
pushed a commit
that referenced
this pull request
Feb 17, 2024
Revert "#2 Merging this if statement with the enclosing one"
Avilad0
pushed a commit
that referenced
this pull request
Feb 17, 2024
Avilad0
pushed a commit
that referenced
this pull request
Feb 17, 2024
Issue-18 private constructor added
Avilad0
pushed a commit
that referenced
this pull request
Feb 17, 2024
Changed the name of the exception from a generic to a dedicated one
JSM2512
pushed a commit
that referenced
this pull request
May 7, 2024
Pull request for StartRecording file
JSM2512
pushed a commit
that referenced
this pull request
May 7, 2024
Issue rilling#92 added a few preventive maintenance on the total number of days used for the chairlift feature and a back button taking the user to the previous activity. Also added the same color code on the fragment_chairs_stats layout to respect Professor Rilling prototype on the requirements document
JSM2512
pushed a commit
that referenced
this pull request
May 7, 2024
…announce-temperature 117 settings voice announcements announce temperature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause for the technical debt
There is a class level variable with the name "markers", and the developer has declared a local variable with the same name, i.e. "markers", inside a function [getXAxisMarkerPositions()] in the same class.
Detected By
SonarCloud integration with the github repo
Issue Location
ChartView.java - line 806
Referred class variable at line 93
Solution
Rename the variable "markers" in function getXAxisMarkerPositions()
Solved in: Branch - Avi_Issue18 , Commit - 51c4d45