Rename "markers" which hides the field declared at line 93 [ChartView.java:806] #18
Comments
Avilad0
added a commit
that referenced
this issue
Feb 15, 2024
Renaming local variable, markers, to xAxisMarkers to not be confused with class level variable with same name.
Avilad0
added a commit
that referenced
this issue
Feb 15, 2024
Renaming local variable, markers, to xAxisMarkers to not be confused with class level variable with same name.
Avilad0
pushed a commit
that referenced
this issue
Feb 17, 2024
Rename method "fromCSV" to prevent any misunderstanding with method "fromCsv"
Avilad0
pushed a commit
that referenced
this issue
Feb 17, 2024
#1 Replace this "switch" statement by "if" statements to increase readability.
Avilad0
pushed a commit
that referenced
this issue
Feb 17, 2024
issue17: arguments passed in the correct order
Avilad0
added a commit
that referenced
this issue
Feb 17, 2024
Renaming local variable, markers, to xAxisMarkers to not be confused with class level variable with same name.
JSM2512
pushed a commit
that referenced
this issue
May 7, 2024
JSM2512
pushed a commit
that referenced
this issue
May 7, 2024
…nnounce-avg-speed-at-end-of-each-run 64 settings voice announcements announce avg speed at end of each run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Technical Debt as detected in SonarCloud
Root Cause for the technical debt
There is a class level variable with the name "markers", and the developer has declared a local variable with the same name, i.e. "markers", inside a function [getXAxisMarkerPositions()] in the same class.
Detected By
SonarCloud integration with the github repo. [Refer screenshot]
Issue Location
ChartView.java - line 806
Referred class variable at line 93
Solution
Rename the variable "markers" in function getXAxisMarkerPositions()
Solved in: Branch - Avi_Issue18 , Commit - 51c4d45
Pull Request to main branch : #19
Commit in : Branch - main, Commit - ec9b329
Screenshot for changed code
Screenshot for SonarCloud state after code changes
The text was updated successfully, but these errors were encountered: