Revert "CDNC-2088 (uber#5094) Add attempt-count to task processing lo…

…gs" (uber#5115) This reverts commit fbe72b3.
IveCode · Feb 23, 2023 · e32116d · e32116d
1 parent 471cf77
commit e32116d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/common/log/tag/tags.go b/common/log/tag/tags.go
@@ -591,8 +591,8 @@ func Attempt(attempt int32) Tag {
 }
 
 // AttemptCount returns tag for AttemptCount
-func AttemptCount(attemptCount int) Tag {
-	return newInt("attempt-count", attemptCount)
+func AttemptCount(attemptCount int64) Tag {
+	return newInt64("attempt-count", attemptCount)
 }
 
 // AttemptStart returns tag for AttemptStart

diff --git a/service/history/task/cross_cluster_task.go b/service/history/task/cross_cluster_task.go
@@ -359,11 +359,7 @@ func (t *crossClusterSourceTask) HandleErr(
 			if attempt > t.maxRetryCount {
 				t.scope.RecordTimer(metrics.TaskAttemptTimerPerDomain, time.Duration(attempt))
 				t.logger.Error("Critical error processing task, retrying.",
-					tag.Error(err),
-					tag.OperationCritical,
-					tag.TaskType(t.GetTaskType()),
-					tag.AttemptCount(t.GetAttempt()),
-				)
+					tag.Error(err), tag.OperationCritical, tag.TaskType(t.GetTaskType()))
 			}
 		}
 	}()

diff --git a/service/history/task/task.go b/service/history/task/task.go
@@ -240,7 +240,6 @@ func (t *taskImpl) HandleErr(
 					tag.Error(err),
 					tag.OperationCritical,
 					tag.TaskType(t.GetTaskType()),
-					tag.AttemptCount(t.GetAttempt()),
 				)
 			}
 		}