[MOB-3769] allowed protocols #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Fix for PR - Allowed Protocols
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 67.47% 67.11% -0.37%
==========================================
Files 63 63
Lines 3806 3822 +16
Branches 440 445 +5
==========================================
- Hits 2568 2565 -3
- Misses 977 995 +18
- Partials 261 262 +1
Continue to review full report at Codecov.
|
Ayyanchira
reviewed
Dec 20, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
Outdated
Show resolved
Hide resolved
Ayyanchira
reviewed
Dec 20, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
Outdated
Show resolved
Hide resolved
Ayyanchira
reviewed
Dec 20, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableDeeplinkManager.java
Outdated
Show resolved
Hide resolved
Ayyanchira
reviewed
Dec 20, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableDeeplinkManager.java
Outdated
Show resolved
Hide resolved
davidtruong
reviewed
Dec 21, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableActionRunner.java
Outdated
Show resolved
Hide resolved
davidtruong
reviewed
Dec 21, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableActionRunner.java
Outdated
Show resolved
Hide resolved
Closed
1. InAppManager no more holds array of allowedProtocols. Its always accessed from IterableConfig. 2. `isUrlOpenAllowed` is now a common utility method in IterableUtil 3. Modified test methods to accomodate the changes
1. Only place to check if the url is allowed is through the Util method which checks the allowedProtocols list from config. 2. Removed method signatures that were introduced because of this 3. Test methods update 4. Logs if the url was blocked
Ayyanchira
reviewed
Dec 22, 2021
| * | ||
| * @param context Context | ||
| * @param action The original action object | ||
| * @param allowedProtocols protocols that the SDK is allowed to open in addition to `https` |
Ayyanchira
force-pushed
the
jay/MOB-3769-allowed-protocols
branch
from
97f21a4 to
4e58592
Compare
…cols Mob 3850 patch for allowed protocols
Ayyanchira
force-pushed
the
jay/MOB-3769-allowed-protocols
branch
from
4e58592 to
c3d5543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
allowedProtocolsintoIterableConfigand makes sure that links that aren'thttpsor in that list are not opened by the SDK