Mob 3850 patch for allowed protocols #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. InAppManager no more holds array of allowedProtocols. Its always accessed from IterableConfig. 2. `isUrlOpenAllowed` is now a common utility method in IterableUtil 3. Modified test methods to accomodate the changes
Codecov Report
@@ Coverage Diff @@
## jay/MOB-3769-allowed-protocols #415 +/- ##
==================================================================
- Coverage 66.99% 66.98% -0.01%
==================================================================
Files 63 63
Lines 3833 3823 -10
Branches 447 445 -2
==================================================================
- Hits 2568 2561 -7
+ Misses 1003 998 -5
- Partials 262 264 +2
Continue to review full report at Codecov.
|
Ayyanchira
force-pushed
the
MOB-3850-Patch-for-allowedProtocols
branch
from
4623213 to
ce2dcaf
Compare
1. Only place to check if the url is allowed is through the Util method which checks the allowedProtocols list from config. 2. Removed method signatures that were introduced because of this 3. Test methods update 4. Logs if the url was blocked
Ayyanchira
force-pushed
the
MOB-3850-Patch-for-allowedProtocols
branch
from
13efc07 to
2bfb786
Compare
davidtruong
approved these changes
Dec 22, 2021
Contributor
davidtruong
left a comment
davidtruong
left a comment
There was a problem hiding this comment.
Changes look fine per the changes we discussed in MOB-3850.
Ayyanchira
added a commit
that referenced
this pull request
Dec 22, 2021
…cols Mob 3850 patch for allowed protocols
Ayyanchira
added a commit
that referenced
this pull request
Dec 22, 2021
…cols Mob 3850 patch for allowed protocols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
[* MOB-XXXX](https://iterable.atlassian.net/browse/MOB-3850)
✏️ Description
isUrlOpenAllowedis now a common utility method in IterableUtil