Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change descriptions of overwritten media types. #45

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jan 25, 2021

GitHub Issue: Islandora/documentation#1541

Other Relevant Links:

What does this Pull Request do?

Changes the descriptions of the media types

What's new?

  • Changes descriptions to avoid implying that these media are for "local" files.
  • Clarifies that TIFFs and JP2s should be in File, not Image media.
  • Claims that these media have files "stored in Fedora". (since this is Defaults so this is true, for files added through the GUI.)

How should this be tested?

Re-install this feature per @mjordan 's directions, here: Islandora/documentation#1541 (comment)

Does the "Add media" page reflect the new text?

Additional Notes:

Interested parties

@dannylamb @manez

@bseeger
Copy link
Member

bseeger commented Jan 25, 2021

I have one comment above, otherwise the description changes look good to me and are definitely an improvement.

@rosiel
Copy link
Member Author

rosiel commented Jan 26, 2021

I have been trying to make Islandora more explicit and honest about "what is in islandora and what is not". Since these media were overwritten to send items into Fedora, I thought that would be useful for people to know. of course if anyone edits how it's set up, they can/should edit the description.
But if there's no interest in seeing 'in fedora', sure I can remove it.

@rosiel
Copy link
Member Author

rosiel commented Jan 26, 2021

To be honest, i would prefer that duplicate media types had been made, so that there would be "Audio" and "Islandora Audio", etc. In my opinion, knowing whether something is in fedora is an important part of managing a repository. Do you think this is something worth pursuing?

@bseeger
Copy link
Member

bseeger commented Jan 26, 2021

Good question. I'm not sure I have enough of an opinion about it but here are some thoughts I have about multiple media types.

If I'm using Islandora 8, I guess I would assume that all things are "in islandora" - whatever that means to your particular site setup. Maybe that equals Fedora, maybe not.

Is there ever a case, in the same system, where you (as a person creating items) want to have the control over whether or not they are in Fedora? I would think that would be an overall system design - the stakeholders decide if Fedora is being used and then all things are either in it, or not, depending on the decision.

By the time you get to the content manager adding data, the decision has been made and they add items - without having the choice of where they go. They "go in the system". If the stakeholders wanted fedora, they go in fedora. If they didn't, they go in drupal's filesystem setup (maybe it's to disk, maybe S3).

In that sense it would be incredibly confusing to that person to have to chose between two media types. That person doesn't have to know the tech details, they just have to know that they created the object correctly. To me, at that point, Fedora is a tech detail.

This is, of course, assuming the content manager doesn't know the in-depth details about the system. That will vary, site to site.

Basically what I'm suggesting is that whether or not an object goes into fedora is probably not made on a per-object basis, it'll most likely be made on a per-install basis. Do we have use cases that need this decision made on a per-object basis?

I think transparency is a very good thing and don't feel strongly about the wording above (it's fine with me if it says fedora because people can change it if they need to, as you've noted). I do think that having more then one media type per type would be confusing.

@rosiel
Copy link
Member Author

rosiel commented Jan 26, 2021

Sure. I think I'd been envisioning a system where "some things are in islandora" and others weren't. That is, you could add files like hero images, marketing material, logos, etc that would help to decorate your site as it was displayed, but they would not be "in islandora".

I think your idea of a coherent system makes more sense for users.

Good point about "wanting to know if they created the object correctly".

Copy link
Member

@bseeger bseeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see your point, about things that fill out the site. These changes look good to me and function as expected. I'm wondering if others want to weigh in on this or if we can just merge?

Also, I'd been thinking about the Tiff/JP2000 issue for a while - of how to indicate to a user that you have to use File for them - so I appreciate this change.

@manez
Copy link
Member

manez commented Feb 1, 2021

@bseeger If you're happy with these additions, there's no need to wait for others to weigh in 👍

@bseeger bseeger merged commit 3e22bad into Islandora:8.x-1.x Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants