Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List config in Islandora Defaults. #1721

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Dec 3, 2020

Purpose / why

Because what Islandora Defaults contains was not yet documented.

What changes were made?

New page, listing all the config entities in Islandora Defaults.

Verification

Spin it up locally, and read through it.

Interested Parties

@dannylamb @Islandora/documentation

Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?


|Name |Description |Comments |
|--- |--- |--- |
|Audio (audio) | A locally hosted audio file. | This is Drupal's built-in Audio media type. Islandora Defaults overwrites the field storage so that it is not actually a locally hosted file. The description is misleading. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but instead of documenting how it's misleading here, we should update the description as a follow up task so we no longer have to point that out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|--- |--- |--- |
|Audio (audio) | A locally hosted audio file. | This is Drupal's built-in Audio media type. Islandora Defaults overwrites the field storage so that it is not actually a locally hosted file. The description is misleading. |
|Document (document) | An uploaded file or document, such as a PDF. | This is Drupal's built-in Document media type. Islandora Defaults overwrites the field storage so that it is not actually a locally hosted file. The description is misleading.|
|File (file) | Use local files for reusable media. ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a description here


|Name |Description |Comments |
|--- |--- |--- |
|Islandora Access (islandora_access) |Terms used to limit, restrict or coordinate access | Not sure if they actually do affect access. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of Not sure if they actually do affect access., how about Meant to be used with permissions_by_term. The vocabulary is unpopulated by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

|Name |Description |Comments |
|--- |--- |--- |
|Islandora Access (islandora_access) |Terms used to limit, restrict or coordinate access | Not sure if they actually do affect access. |
|Islandora Display (islandora_display) |Terms used to alter how a repository item is viewed. ie. basic image vs large image | Check if/how this gets populated.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is populated by a migration that's run during install. Everything comes from this csv https://github.com/Islandora/islandora/blob/8.x-1.x/migrate/tags.csv:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. thanks.

|Media |Image |Default||
|Media |Video |Default||
|Taxonomy Term |Islandora Display |Default||
|Taxonomy Term |Islandora Media Use |Default|This vocabulary is not defined in this module.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the vocabs that aren't defined in defaults or maybe mention that they are defined by the islandora_core_feature


### Form Modes

The following "Default" forms are configured. It is unclear how/if these include Islandora-specific choices such as ordering/grouping or form widget configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These default form modes are minimal changes to Drupal's default form modes. The only significant additions are to show widgets for the Islandora specific fields like field_media_use and field_external_uri.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! thank you!

| Content | Binary | |
| Content | Open Seadragon | |
| Content | PDFjs | |
| Content | Teaser | This seems to be a re-definition of the built-in "Teaser" view mode. |
Copy link
Contributor

@dannylamb dannylamb Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It totally is. You can use firmer language that 'seems to be'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so why's it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just add the shortened "summary" text of the description to the teaser.

| Media | PDFjs | |


The following display modes are configured. It is unclear how/if the "Default", "Source", and "Teaser" display modes include any Islandora-specific choices such as ordering/grouping or display widget configuration. "Media EVAs (display_media)" is a view provided by the Islandora core feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'source' display modes present just the file. Probably too much to throw at the user now, but that display mode is what's used by the EVA's to show the file.

"Default" is usually our best guess as to what you want to see. Which at this point is just basically everything with little to no formatting.


| Type | Bundle | Comments |
|---------------|---------------------|----------|
| node | islandora_object | Do not hide untranslatable fields. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you hide an untranslatable field?

|-----------------------------------------------------|------------------------------------------------|----------------------------------------------------------------------------------------------|--------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------|
| IIIF Manifest (iiif_manifest) | Generates IIIF manifests for paged content | REST Export (/node/%node/book-manifest);<br/>REST Export - Single node (/node/%node/manifest) | | |
| Members (members) | Displays members for content. | Members (block) | Show an unformatted list of published nodes that are "Member of" the current node (from URL), formatted as "Teaser"s, paged to 10 items. | |
| OpenSeadragon Media EVAs (openseadragon_media_evas) | Displays media for content as EVA's per model. | Original File;<br/>Preservation Master;<br/>Service File | Show 1 Media that is "Media of" the node (from URL) and having Media Use corresponding to each Display (Original file, etc.). The Media is rendered with display mode OpenSeadragon. See media.\*.open_seadragon under "Display Modes." The description's "per model" should read "per media use". Provides the EVA used in the islandora_object.open_seadragon display mode. The Preservation Master and Service File displays are not used. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment's a mouthful. Maybe say "Provides fields to show files using the Openseadragon viewer. Each Media Use gets its own field, so the user can choose between displaying the Original File or a derivative such as the Service File."?

| IIIF Manifest (iiif_manifest) | Generates IIIF manifests for paged content | REST Export (/node/%node/book-manifest);<br/>REST Export - Single node (/node/%node/manifest) | | |
| Members (members) | Displays members for content. | Members (block) | Show an unformatted list of published nodes that are "Member of" the current node (from URL), formatted as "Teaser"s, paged to 10 items. | |
| OpenSeadragon Media EVAs (openseadragon_media_evas) | Displays media for content as EVA's per model. | Original File;<br/>Preservation Master;<br/>Service File | Show 1 Media that is "Media of" the node (from URL) and having Media Use corresponding to each Display (Original file, etc.). The Media is rendered with display mode OpenSeadragon. See media.\*.open_seadragon under "Display Modes." The description's "per model" should read "per media use". Provides the EVA used in the islandora_object.open_seadragon display mode. The Preservation Master and Service File displays are not used. |
| PDFjs Media EVAs (pdfjs_media_evas) | Displays media for content as EVA's per model. | Original File;<br/>Preservation Master;<br/>Service File | Show 1 Media that is "Media of" the node (from URL) and having Media Use corresponding to each Display (Original file, etc.). The Media is rendered with display mode PDFjs. The description's "per model" should read "per media use". Provides the EVA used in the islandora_object.pdfjs display mode. The Preservation Master and Service File displays are not used. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above but for pdfjs

## Actions
| Name | Plugin | Comments|
|---|---|---|
| Audio - Generate a service file from an original file (audio_generate_a_service_file_from_an_original_file) | generate_audio_derivative |use the Homarus queue to generate an "audio" media tagged #ServiceFile from the #OriginalFile with mimetype audio/mpeg, using the libmp3lame codec and audio quality 5, and save in the public filesystem in a folder for the year and month. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First word of the comments need to be capitalized.

|resource_types|"Text"|"A resource consisting primarily of words for reading"|http://purl.org/dc/dcmitype/Text|


core.base_field_override.node.islandora_object.changed.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno about these things. They're just auto-provided by Drupal because we configure these fields settings.


## User Roles

The role fedoraadmin (machine name: `fedoraadmin`) is defined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a big warning here that you need this role to put stuff in fedora.


## Fields

This is at the end of this document because it's not particularly useful yet - there's so much information it's not clear what needs to be here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you don't need to list out every field setting. The new fields are definitely important. The field storage basically covers all the new fields.

- field.storage.media.field_access_terms.yml


### Overrides of core fields (?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I dunno either. I probably wouldn't bother with these.

@dannylamb
Copy link
Contributor

Whelp, left a brain dump for ya @rosiel. Hopefully some of that's useful.

@manez
Copy link
Member

manez commented Feb 24, 2021

Determined in the Feb 23 DIG meeting that this is good to go 👍

@dannylamb dannylamb merged commit 585001d into Islandora:main Feb 24, 2021
@rosiel rosiel deleted the islandora-defaults branch December 10, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants