Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about new publisher field. #2293

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add note about new publisher field. #2293

merged 2 commits into from
Apr 18, 2024

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Mar 24, 2024

Purpose / why

After Islandora-Devops/islandora-starter-site#138 is merged:

What changes were made?

Added note about what happened with publisher and why.

Verification

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link

github-actions bot commented Mar 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-18 01:35 UTC

@rosiel rosiel marked this pull request as ready for review April 4, 2024 12:19
@aOelschlager aOelschlager self-requested a review April 10, 2024 17:28
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aOelschlager aOelschlager merged commit 56c49f1 into main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants