Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate Publisher field. #138

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Mar 13, 2024

Issue #137

This PR should create a new field for Publisher, as requested by the metadata Interest Group.

To test: Spin up a fresh site with this set of configs.

  • The publisher field should show up in the Repository Item form (In the Publication Details and Dates section)
  • it should display on the Item (consistently with other fields)
  • It should be indexed in Solr (can test by adding content and seeing it show up in the views listed in the next bullet.)
  • It should show up as a "field" in search result displays in the Collection View and Global Search Results
  • It should show up (as dc11:publisher) in the RDF at ?_format=jsonld
  • It should show up as dc:publisher in the OAI DC (see link at bottom of node page)
  • It should show up as mods/originInfo/publisher in OAI MODS (see link at bottom of node page).
  • it should show up as a facet block called "Publisher" on both the collection view and the global search
  • It should show up in the APA citation format at the bottom of the page.

Please add a comment if there are places I've forgotten!

@rosiel
Copy link
Contributor Author

rosiel commented Mar 15, 2024

It occurs to me that Citation Select is a place I did forget, where we could* set this. However, Citation Select only lets us map one field, for all content, to (csl) publisher. Right now it's using Linked Agent but we could switch it over, resulting in nodes that use Contributors (Linked Agent) for publisher not having a publisher in the citation.

@rosiel
Copy link
Contributor Author

rosiel commented Mar 20, 2024

discussed in the tech call. Decided to go all-in on the Publisher field, and remove relators:pbl from the Contributors field.

@rosiel rosiel marked this pull request as draft March 20, 2024 17:31
@rosiel
Copy link
Contributor Author

rosiel commented Mar 22, 2024

I've gone "all in" on publisher. I removed it from the linked agent options.

I also added and placed a facet, both to the main and the collection search views.

I also configured it as an option in the "fielded search" dropdown, since it's fulltext.

@rosiel rosiel marked this pull request as ready for review March 22, 2024 15:41
@seth-shaw-asu seth-shaw-asu requested a review from alxp March 27, 2024 17:17
@joecorall
Copy link
Contributor

This is a great change! e.g. our Contributor facet was getting pretty heavily weighted by publishers. Now that publishers are their own field/facet the search/browse is much better!

I haven't full tested this PR (I just made the changes manually), but did write a script to move the publisher linked agents to the new field_publisher storage for existing sites: lehigh-university-libraries/lehigh_islandora@cbd30e5

@alxp
Copy link
Contributor

alxp commented Apr 2, 2024

Tested by spinning up[ a new ISLE-DC and replacing the Git URL in the make starter_dev command.

The field is in the node add form, and there's a helpful note under the contributors widget to add publisher to its own field.

JSON-LD has the field as expected:

{"@graph":[{"@id":"https:\/\/islandora.traefik.me\/node\/1","@type":["http:\/\/pcdm.org\/models#Object","https:\/\/schema.org\/Book"],"http:\/\/schema.org\/author":[{"@id":"https:\/\/islandora.traefik.me\/user\/1"}],"http:\/\/purl.org\/dc\/terms\/title":[{"@value":"Test object with  publisher field","@language":"en"}],"http:\/\/schema.org\/dateCreated":[{"@value":"2024-04-02T22:27:25+00:00","@type":"http:\/\/www.w3.org\/2001\/XMLSchema#dateTime"}],"http:\/\/schema.org\/dateModified":[{"@value":"2024-04-02T22:27:25+00:00","@type":"http:\/\/www.w3.org\/2001\/XMLSchema#dateTime"}],"http:\/\/purl.org\/dc\/elements\/1.1\/publisher":[{"@value":"Words on Paper","@type":"http:\/\/www.w3.org\/2001\/XMLSchema#string"}],"http:\/\/schema.org\/sameAs":[{"@id":"https:\/\/islandora.traefik.me\/node\/1"}]},{"@id":"https:\/\/islandora.traefik.me\/user\/1","@type":["http:\/\/schema.org\/Person"]}]}

It's indexed in Solr

image

It shows up as a citation:

Test Object With Publisher Field. Words on Paper.

Review all citations for accuracy.

@alxp alxp merged commit 69d1933 into Islandora-Devops:main Apr 2, 2024
2 checks passed
@rosiel
Copy link
Contributor Author

rosiel commented Apr 3, 2024

@joecorall this is hot on the heels of another pull request that lets you exclude/include relators from a facet. So double fix!

I too wrote a script and made a video about it. I'll link them all from the release notes.

@rosiel rosiel deleted the publisher branch April 3, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants