Have docker nginx logs print the client IP #328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use realip nginx module to have docker logs print the client IP in its logs rather than the traefik private IP.
I made this code change in the GitHub Cloud IDE and inadvertently committed to the main branch: 78ab2d5 which I then reverted 95ecba3 (and canceled the GitHub Actions). Should we prevent direct pushes to main in this repo without a PR? When I clicked the "Commit" button in the GitHub IDE I thought it was going to prompt me to enter a branch name is how I made the mistake.
Before
After