Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newspaper issues accordian view #60

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Newspaper issues accordian view #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
628fd43
newspaper accordian view
Natkeeran Feb 24, 2023
3654f11
Remove old view and context.
rosiel Feb 27, 2023
f86f145
Merge pull request #1 from rosiel/newspaper_accordian_view_3
Natkeeran Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions composer.json
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,19 @@
"type": "zip"
}
}
},
{
"type": "package",
"package": {
"name": "islandora/views_nested_details",
"version": "1.0.0-beta1",
"type": "drupal-module",
"source": {
"url": "https://github.com/Islandora-Labs/views_nested_details",
"type": "git",
"reference":"1.0.0-beta1"
Comment on lines +32 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this section a workaround because it's not on packagist? Should we just put it on packagist?

Second, can we require a version range rather than a specific version? Relatedly, should we release a 1.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this later.

}
}
}
],
"require": {
Expand Down Expand Up @@ -56,6 +69,7 @@
"islandora/controlled_access_terms": "^2",
"islandora/islandora": "^2",
"islandora/openseadragon": "^2",
"islandora/views_nested_details": "^1.0.0-beta",
"library/pdf.js": "^2.4",
"mjordan/islandora_workbench_integration": "^1.0"
},
Expand Down
47 changes: 28 additions & 19 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions config/sync/context.context.newspaper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
uuid: 1efd72d3-7a06-4f43-9249-3ccea32d300d
uuid: 7b1d17e2-aa1a-4740-9c7c-d110f6f34b84
langcode: en
status: true
dependencies:
config:
- views.view.newspapers
- views.view.newspaper_issues_accordion_view
module:
- islandora
- views
Expand All @@ -27,15 +27,15 @@ reactions:
id: blocks
uuid: 83998c46-0118-4deb-9c12-10e33d02b49b
blocks:
ed4c4f13-b90a-4274-9d88-ef9d69c8c34b:
uuid: ed4c4f13-b90a-4274-9d88-ef9d69c8c34b
id: 'views_block:newspapers-block_1'
8a31d625-66c6-44ae-98b4-32b8789325b0:
uuid: 8a31d625-66c6-44ae-98b4-32b8789325b0
id: 'views_block:newspaper_issues_accordion_view-block_1'
label: ''
provider: views
label_display: '0'
region: content
weight: '0'
custom_id: views_block_newspapers_block_1
custom_id: views_block_newspaper_issues_accordion_view_block_1
theme: olivero
css_class: ''
unique: 0
Expand Down
1 change: 1 addition & 0 deletions config/sync/core.extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ module:
user: 0
view_mode_switch: 0
views_data_export: 0
views_nested_details: 0
views_ui: 0
content_translation: 10
views: 10
Expand Down
14 changes: 8 additions & 6 deletions config/sync/views.view.newspapers.yml → ....view.newspaper_issues_accordion_view.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
uuid: 35ed259c-70a3-4ebb-974c-7c3ec932376f
uuid: eb1fb208-6666-42af-8eca-bc239ae9a619
langcode: en
status: true
dependencies:
Expand All @@ -8,7 +8,8 @@ dependencies:
- controlled_access_terms
- node
- user
id: newspapers
- views_nested_details
id: newspaper_issues_accordion_view
label: 'Newspaper Issues'
module: views
description: 'List the children of a node, by date issued.'
Expand Down Expand Up @@ -587,18 +588,19 @@ display:
default_group_multiple: { }
group_items: { }
style:
type: html_list
type: nested_details
options:
grouping:
-
field: field_edtf_date_issued
rendered: true
rendered_strip: false
-
field: field_edtf_date_issued_1
rendered: true
rendered_strip: false
row_class: ''
default_row_class: true
type: ul
wrapper_class: item-list
class: ''
row:
type: fields
options:
Expand Down