Newspaper issues accordian view #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old view and context.
rosiel
reviewed
Feb 28, 2023
Comment on lines
+32
to
+37
| "version": "1.0.0-beta1", | ||
| "type": "drupal-module", | ||
| "source": { | ||
| "url": "https://github.com/Islandora-Labs/views_nested_details", | ||
| "type": "git", | ||
| "reference":"1.0.0-beta1" |
There was a problem hiding this comment.
Is this section a workaround because it's not on packagist? Should we just put it on packagist?
Second, can we require a version range rather than a specific version? Relatedly, should we release a 1.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides accordion view for newspaper issues.
It installs the views_nested_details in Islandora Labs.
And adds a newspaper block view, which is a mainly a view formatter change to the existing newspaper issue view.
Further, it provides a context for the view block placement.