Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 does not support git@hyphenated-name.com:org/repo.git #50

Closed
crenshaw-dev opened this issue Jul 27, 2022 · 1 comment · Fixed by #51
Closed

7.0 does not support git@hyphenated-name.com:org/repo.git #50

crenshaw-dev opened this issue Jul 27, 2022 · 1 comment · Fixed by #51

Comments

@crenshaw-dev
Copy link

While trying to upgrade Argo CD to use a newer version of git-url-parse, a failing test showed that there's a limitation in 7.0. It does not support git@ URLs when the domain name contains a hyphen. For example:

git@github.my-enterprise.com:my-org/my-repo.git

     ❌ should support git@github.my-enterprise.com:my-org/my-repo.git
     Error: Expected { protocols: [ 'file' ], protocol: 'file', port: '', resource: '', user: '', password: '', pathname: '', hash: '', search: '', href: 'git@github.my-enterprise.com:my-org/my-repo.git', query: {} } to equal { protocols: [ 'ssh' ], protocol: 'ssh', port: '', resource: 'github.my-enterprise.com', user: 'git', password: '', pathname: '/my-org/my-repo.git', hash: '', search: '', query: {}, href: 'git@github.my-enterprise.com:my-org/my-repo.git' }
@crenshaw-dev
Copy link
Author

@IonicaBizau can you cut new versions of git-up/git-url-parse to include this? Looks like git-up still points at 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant