fix: support hyphens in git@ URLs (IonicaBizau#50)

crenshaw-dev · Jul 27, 2022 · 8223f2a · 8223f2a
1 parent 155b10a
commit 8223f2a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -37,7 +37,7 @@ import normalizeUrl from "normalize-url";
 const parseUrl = (url, normalize = false) => {
 
     // Constants
-    const GIT_RE = /((git@|http(s)?:\/\/)([\w\.@]+)(\/|:))(([\~,\w,\-,\_,\/]+)(.git){0,1}((\/){0,1}))/
+    const GIT_RE = /((git@|http(s)?:\/\/)([\w\.\-@]+)(\/|:))(([\~,\w,\-,\_,\/]+)(.git){0,1}((\/){0,1}))/
 
     if (typeof url !== "string" || !url.trim()) {
         const err = new Error("Invalid url.")

diff --git a/test/index.js b/test/index.js
@@ -88,6 +88,21 @@ const INPUTS = [
           , query: {}
         }
     ]
+  , [
+        ["git@github.my-enterprise.com:my-org/my-repo.git", false],
+        {
+            protocols: [ 'ssh' ]
+            , protocol: 'ssh'
+            , port: ''
+            , resource: 'github.my-enterprise.com'
+            , user: 'git'
+            , password: ''
+            , pathname: '/my-org/my-repo.git'
+            , hash: ''
+            , search: ''
+            , query: {}
+        }
+    ]
 ];
 
 tester.describe("check urls", test => {