Use regex to check that the port is a series of digits 0-9. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2022
ronyeh
added a commit
to ronyeh/vexflow4
that referenced
this pull request
Jan 29, 2022
Remove the patch after the fix is merged. The issue is filed at IonicaBizau/parse-path#32 The patch manager https://www.npmjs.com/package/patch-package
|
Thanks for merging! Would it be possible to make a new NPM patch release so that our project can make use of the fix? Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
From the URL spec at https://url.spec.whatwg.org/#url-port-string
A URL-port string must be one of the following:
This example from Microsoft uses the
\d+regex, so that seems like a fine way to match port numbers:https://docs.microsoft.com/en-us/dotnet/standard/base-types/how-to-extract-a-protocol-and-port-number-from-a-url