Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not parse pathname when git username is a hexadecimal number. #31

Closed
ronyeh opened this issue Jan 26, 2022 · 0 comments · Fixed by #32
Closed

Does not parse pathname when git username is a hexadecimal number. #31

ronyeh opened this issue Jan 26, 2022 · 0 comments · Fixed by #32

Comments

@ronyeh
Copy link
Contributor

ronyeh commented Jan 26, 2022 •
edited
Loading

For example:

git@github.com:0xABC/git-stats.git

This is because Number(...) converts a hex string to a number. However, URL ports can only be decimal numbers:

parse-path/lib/index.js

Lines 94 to 95 in 6098fcb

output.port = Number(splits[1]);
if (isNaN(output.port)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use regex to check that the port is a series of digits 0-9. ronyeh/parse-path
1 participant
@ronyeh