Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depthai Wrapper #1

Merged
merged 28 commits into from
Sep 28, 2020
Merged

Depthai Wrapper #1

merged 28 commits into from
Sep 28, 2020

Conversation

saching13
Copy link
Collaborator

Created a DepthAI wrapper to get different streams sent from OAK-D

depthai_wrapper file initializes and creates the device pipeline. It also creates a CV::Mat place holders for the object to be fetched from the device. These frames can be fetched using get_frames() function.

Copy link

@deepaktalwardt deepaktalwardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add more explanations. Plus there are a lot of improvements that can be made.

Copy link

@deepaktalwardt deepaktalwardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better! Just a few small things.

saching13 and others added 6 commits September 26, 2020 15:39
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Copy link

@deepaktalwardt deepaktalwardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the final changes I suggested, then it should be ready to be merged 👍

saching13 and others added 7 commits September 26, 2020 19:37
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Co-authored-by: Deepak Talwar <deepaktalwardt@gmail.com>
Copy link

@deepaktalwardt deepaktalwardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good :) Just replied to the last open things. Feel free to merge after those are resolved.

@saching13 saching13 merged commit c18f556 into develop Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants