Old peers tracing was erroneously called in new tracing #3880

jutaro · 2022-05-20T07:54:06Z

/nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS
cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric.
CallStack (from HasCallStack):
error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics

deepfire

Looks good, thank you @jutaro !

deepfire · 2022-05-23T22:14:26Z

bors r+

3852: cardano-tracer: init RTView r=deepfire a=denisshevchenko This is pre-MVP for RTView. 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics 3882: Fix datum in tx and ref scripts r=Jimbo4350 a=ch1bo (Couldn't reopen #3881, so created this one) :snowflake: Add a roundtrip property `TxBodyContent -> TxBody -> TxBodyContent` This helped in fixing the :bug: and uncover the two additional gaps in the code. I'm not 100% happy with the current implementation of the property though! I needed to accept two exceptions to the general `===`: 1. `SimpleScriptV1` reference scripts may become `SimpleScriptV2` 2. A `TxOutDatumHash` + a matching `ScriptData` may become a `TxOutDatumTx` :snowflake: Resolve datum hash + matching datum in transaction to `TxOutDatumInTx`, fixes #3866 ❄️ Add missing script languages to `scriptLanguageSupportedInEra` for `BabbageEra` ❄️ Allow scripts in any language as refeference scripts Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de> Co-authored-by: Sebastian Nagel <sebastian.nagel@ncoding.at>

iohk-bors · 2022-05-24T01:40:51Z

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Jimbo4350

One question and please squash the commit

Jimbo4350 · 2022-05-24T13:06:27Z

cardano-node/src/Cardano/Node/Run.hs

+              networkMagic
+              nodeKernelData
+              p2pMode
+          handleSimpleNode runP p2pMode tracers nc


Why do we no longer need

`finally` forM_ mLoggingLayer shutdownLoggingLayer

when using the trace dispatcher?

No shutdown handler is needed for new tracing. trace-dispatcher just starts one queuing thread, but it shuts down graceful without further action. The same applies to trace-forward

deepfire · 2022-05-27T15:20:58Z

bors r+

3824: tx-generator: fix for Babbage r=deepfire a=MarcFontaine 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de>

iohk-bors · 2022-05-27T15:45:07Z

Build failed (retrying...):

ci/hydra-build:required

3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics Co-authored-by: Yupanqui <jnf@arcor.de>

iohk-bors · 2022-05-27T18:13:18Z

Timed out.

deepfire · 2022-05-27T20:35:48Z

bors r+

3824: tx-generator: fix for Babbage r=deepfire a=MarcFontaine 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de>

iohk-bors · 2022-05-27T20:48:04Z

Build failed (retrying...):

ci/hydra-build:required

deepfire · 2022-05-27T20:54:32Z

bors r+

iohk-bors · 2022-05-27T20:54:34Z

Already running a review

3824: tx-generator: fix for Babbage r=deepfire a=MarcFontaine 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics 3930: cardano-tracer: remove symlink, fix logs cut off. r=deepfire a=denisshevchenko Closes #3892 Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de> Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>

iohk-bors · 2022-05-27T21:12:58Z

This PR was included in a batch that was canceled, it will be automatically retried

deepfire · 2022-05-27T21:13:10Z

bors r-

iohk-bors · 2022-05-27T21:13:13Z

Canceled.

deepfire · 2022-05-27T21:13:59Z

bors r+

3824: tx-generator: fix for Babbage r=deepfire a=MarcFontaine 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics 3930: cardano-tracer: remove symlink, fix logs cut off. r=deepfire a=denisshevchenko Closes #3892 Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de> Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>

deepfire · 2022-05-27T21:25:35Z

bors r-

iohk-bors · 2022-05-27T21:25:37Z

Canceled.

deepfire · 2022-05-27T21:38:40Z

bors r+

3824: tx-generator: fix for Babbage r=deepfire a=MarcFontaine 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics 3930: cardano-tracer: remove symlink, fix logs cut off. r=deepfire a=denisshevchenko Closes #3892 Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de> Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>

iohk-bors · 2022-05-27T22:20:30Z

This PR was included in a batch that was canceled, it will be automatically retried

deepfire · 2022-05-27T22:20:32Z

bors r-

iohk-bors · 2022-05-27T22:20:36Z

Canceled.

deepfire · 2022-05-27T22:23:17Z

bors r+

3824: tx-generator: fix for Babbage r=deepfire a=MarcFontaine 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics 3930: cardano-tracer: remove symlink, fix logs cut off. r=deepfire a=denisshevchenko Closes #3892 Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de> Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>

iohk-bors · 2022-05-27T23:32:37Z

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

deepfire · 2022-05-27T23:49:59Z

Force merging, because all constituents were approved and passed tests.

BORS is ridiculous.

jutaro self-assigned this May 20, 2022

jutaro requested a review from deepfire May 20, 2022 07:54

jutaro added the bug Something isn't working label May 20, 2022

jutaro marked this pull request as ready for review May 20, 2022 12:54

jutaro requested a review from denisshevchenko as a code owner May 20, 2022 12:54

deepfire force-pushed the peers-bug branch 2 times, most recently from f10f19d to 32f3e9a Compare May 23, 2022 20:18

jutaro requested review from DavidEichmann, dcoutts, Jimbo4350, erikd, newhoggy, nc6 and JaredCorduan as code owners May 23, 2022 20:18

deepfire approved these changes May 23, 2022

View reviewed changes

deepfire force-pushed the peers-bug branch from 32f3e9a to 7b22b9d Compare May 23, 2022 22:13

deepfire requested review from newhoggy and removed request for newhoggy May 24, 2022 12:25

Jimbo4350 reviewed May 24, 2022

View reviewed changes

deepfire force-pushed the peers-bug branch 4 times, most recently from 094b593 to af0bd0e Compare May 27, 2022 12:29

Jimbo4350 approved these changes May 27, 2022

View reviewed changes

deepfire force-pushed the peers-bug branch from af0bd0e to 000ae43 Compare May 27, 2022 15:03

cardano-node: startup code

e51fcd7

deepfire force-pushed the peers-bug branch from 000ae43 to e51fcd7 Compare May 27, 2022 15:03

deepfire merged commit 0c8312d into master May 27, 2022

iohk-bors bot deleted the peers-bug branch May 27, 2022 23:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Old peers tracing was erroneously called in new tracing #3880

Old peers tracing was erroneously called in new tracing #3880

jutaro commented May 20, 2022

deepfire left a comment

deepfire commented May 23, 2022

iohk-bors bot commented May 24, 2022

Jimbo4350 left a comment

Jimbo4350 May 24, 2022

jutaro May 25, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

Old peers tracing was erroneously called in new tracing #3880

Old peers tracing was erroneously called in new tracing #3880

Conversation

jutaro commented May 20, 2022

deepfire left a comment

Choose a reason for hiding this comment

deepfire commented May 23, 2022

iohk-bors bot commented May 24, 2022

Jimbo4350 left a comment

Choose a reason for hiding this comment

Jimbo4350 May 24, 2022

Choose a reason for hiding this comment

jutaro May 25, 2022

Choose a reason for hiding this comment

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022

iohk-bors bot commented May 27, 2022

deepfire commented May 27, 2022