cardano-tracer: init RTView #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
3 times, most recently
from
8f34813
to
ee7dacd
Compare
denisshevchenko
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
c6cf7ea
to
217d70b
Compare
denisshevchenko
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
217d70b
to
9c97b64
Compare
denisshevchenko
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
4 times, most recently
from
0150080
to
ecebefe
Compare
deepfire
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
86de846
to
ab3da99
Compare
deepfire
approved these changes
May 23, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 23, 2022
3852: cardano-tracer: init RTView r=denisshevchenko a=denisshevchenko This is pre-MVP for RTView. 3882: Fix datum in tx and ref scripts r=Jimbo4350 a=ch1bo (Couldn't reopen #3881, so created this one) :snowflake: Add a roundtrip property `TxBodyContent -> TxBody -> TxBodyContent` This helped in fixing the :bug: and uncover the two additional gaps in the code. I'm not 100% happy with the current implementation of the property though! I needed to accept two exceptions to the general `===`: 1. `SimpleScriptV1` reference scripts may become `SimpleScriptV2` 2. A `TxOutDatumHash` + a matching `ScriptData` may become a `TxOutDatumTx` :snowflake: Resolve datum hash + matching datum in transaction to `TxOutDatumInTx`, fixes #3866 ❄️ Add missing script languages to `scriptLanguageSupportedInEra` for `BabbageEra` ❄️ Allow scripts in any language as refeference scripts Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Sebastian Nagel <sebastian.nagel@ncoding.at>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 23, 2022
3852: cardano-tracer: init RTView r=deepfire a=denisshevchenko This is pre-MVP for RTView. 3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro /nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric. CallStack (from HasCallStack): error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics 3882: Fix datum in tx and ref scripts r=Jimbo4350 a=ch1bo (Couldn't reopen #3881, so created this one) :snowflake: Add a roundtrip property `TxBodyContent -> TxBody -> TxBodyContent` This helped in fixing the :bug: and uncover the two additional gaps in the code. I'm not 100% happy with the current implementation of the property though! I needed to accept two exceptions to the general `===`: 1. `SimpleScriptV1` reference scripts may become `SimpleScriptV2` 2. A `TxOutDatumHash` + a matching `ScriptData` may become a `TxOutDatumTx` :snowflake: Resolve datum hash + matching datum in transaction to `TxOutDatumInTx`, fixes #3866 ❄️ Add missing script languages to `scriptLanguageSupportedInEra` for `BabbageEra` ❄️ Allow scripts in any language as refeference scripts Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de> Co-authored-by: Sebastian Nagel <sebastian.nagel@ncoding.at>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Jimbo4350
approved these changes
May 24, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 24, 2022
3852: cardano-tracer: init RTView r=denisshevchenko a=denisshevchenko This is pre-MVP for RTView. 3898: Standardised payment key directory structure r=newhoggy a=newhoggy Now payment keys live in `example/utxo-keys` for both the alonzo and babbage testnets. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: John Ky <john.ky@iohk.io>
|
This PR was included in a batch that timed out, it will be automatically retried |
deepfire
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
ab3da99
to
8d4b5b1
Compare
|
Canceled. |
|
bors r+ |
|
bors r- |
|
Canceled. |
deepfire
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
8d4b5b1
to
756111c
Compare
|
bors r_ |
|
bors r+ |
|
Timed out. |
|
bors r+ |
|
Build failed: |
deepfire
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
756111c
to
257397c
Compare
deepfire
force-pushed
the
cad-3845-rtview-in-cardano-tracer
branch
from
257397c
to
443a41e
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pre-MVP for RTView.