Conversation
* chore: update intmax2-zkp deps * feat: delete circuit dependency * feat: add some data * docs: update readme & testdata * chore: update proof * chore: fix limb error
* feat: entry status replace * feat: wip strategy replacement * feat: impl seperate group * feat: optional cursor * feat: impl fetch batch * feat: impl fetch batch wasm --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the project's history and strategy modules to unify data handling patterns and simplifies gnark-server configuration. The key changes include moving from separate settled/pending/timeout structures to a unified history entry system and removing circuit-specific configurations in favor of a single configuration.
- Unified history entry system with EntryStatus enum replacing separate category structures
- Removed circuit-specific parameters from gnark-server, consolidating to single configuration
- Added batch fetching functionality for history entries
Reviewed Changes
Copilot reviewed 30 out of 39 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| wasm/src/js_types/history.rs | Updates import path for EntryStatus and HistoryEntry types |
| wasm/src/history.rs | Adds batch fetching functions for deposits, transfers, and transactions |
| job-servers/gnark-server/utils/pis.go | Adds CalculateInputDigest function for public input validation |
| job-servers/gnark-server/setup/main.go | Removes circuit-specific command line parameters and paths |
| job-servers/gnark-server/main.go | Removes circuit parameter requirement |
| job-servers/gnark-server/handlers/prove.go | Adds verifier data parameter and input hash calculation |
| client-sdk/src/client/strategy/*.rs | Refactors to use unified HistoryEntry system instead of separate structures |
| client-sdk/src/client/history.rs | Simplifies history fetching by leveraging unified entry system |
| client-sdk/src/client/client.rs | Updates to use new unified history structures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.