Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates gnark by refactoring the circuit verification system to remove circuit-specific configurations and unify the implementation. The changes consolidate multiple circuit data directories into a single configuration and introduce a new input digest calculation mechanism for enhanced verification.
- Consolidates circuit-specific data directories into a unified data structure
- Introduces input digest calculation for public inputs validation
- Removes circuit name parameters from initialization and execution flows
Reviewed Changes
Copilot reviewed 16 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
job-servers/gnark-server/utils/pis.go |
Adds new CalculateInputDigest function for validating and computing digest of 8 public inputs |
job-servers/gnark-server/setup/main.go |
Removes circuit name parameter and updates paths to use unified data directory |
job-servers/gnark-server/main.go |
Removes circuit name flag and simplifies initialization |
job-servers/gnark-server/handlers/prove.go |
Updates prove handler to accept verifier data and use new input digest calculation |
job-servers/gnark-server/circuit/verifierCircuit.go |
Refactors circuit structure to use new digest validation and public input verification |
job-servers/gnark-server/circuitData/circuitData.go |
Simplifies circuit data loading by removing circuit-specific paths |
| Various data files | Removes circuit-specific directories and adds unified test data |
Cargo.toml files |
Updates dependency branch to "dev" |
Comments suppressed due to low confidence (1)
job-servers/gnark-server/handlers/prove.go:68
- [nitpick] The parameter name
vdRawis unclear. Consider renaming it toverifierDataRawfor better readability.
func (s *State) prove(jobId string, proofRaw types.ProofWithPublicInputsRaw, vdRaw types.VerifierOnlyCircuitDataRaw) error {
smallbabybear
approved these changes
Aug 7, 2025
signature18632
pushed a commit
that referenced
this pull request
Aug 16, 2025
* feat: Integrated gnark (#448) * chore: update intmax2-zkp deps * feat: delete circuit dependency * feat: add some data * docs: update readme & testdata * chore: update proof * chore: fix limb error * Single history status (#453) * feat: entry status replace * feat: wip strategy replacement * feat: impl seperate group * feat: optional cursor * feat: impl fetch batch * feat: impl fetch batch wasm --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> --------- Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com>
signature18632
added a commit
that referenced
this pull request
Oct 31, 2025
* feat: Integrated gnark (#448) * chore: update intmax2-zkp deps * feat: delete circuit dependency * feat: add some data * docs: update readme & testdata * chore: update proof * chore: fix limb error * Single history status (#453) * feat: entry status replace * feat: wip strategy replacement * feat: impl seperate group * feat: optional cursor * feat: impl fetch batch * feat: impl fetch batch wasm --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> * change os (#458) * feat: add get used memo func for wasm (#469) * feat: add get used memo func for wasm * fix: fix typo for ci * docs: added comprehensive docs for all nodes (#446) * chore: update docs * docs: add block builder docs * docs: add balance prover readme * docs: client sdk * docs: fix client sdk docs * docs: add validity prover docs * docs: add block builder data structure * docs: update block builder * docs: add withdrawal server docs * docs: add validity prover worker tasks * docs: delete legacy store vault server * docs: add pruning docs * docs: update validity prover docs * docs: update * docs: interface * docs: add Troubleshooting * fix: add membership verification during `add_signature` (#465) * fix: add membership verification during add_signature to prevent future panic * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: typo for ci --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add rate limit & reduce max batch size (#464) * feat: add rate limit & reduce max batch size * feat: use wasm time * feat: longer rate limit * feat: remove AGENTS.md * fix: typo * Retry 502 error (#470) --------- Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com> --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> Co-authored-by: signature18632 <intmax18@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
signature18632
added a commit
that referenced
this pull request
Nov 13, 2025
* feat: Integrated gnark (#448) * chore: update intmax2-zkp deps * feat: delete circuit dependency * feat: add some data * docs: update readme & testdata * chore: update proof * chore: fix limb error * Single history status (#453) * feat: entry status replace * feat: wip strategy replacement * feat: impl seperate group * feat: optional cursor * feat: impl fetch batch * feat: impl fetch batch wasm --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> * change os (#458) * feat: add get used memo func for wasm (#469) * feat: add get used memo func for wasm * fix: fix typo for ci * docs: added comprehensive docs for all nodes (#446) * chore: update docs * docs: add block builder docs * docs: add balance prover readme * docs: client sdk * docs: fix client sdk docs * docs: add validity prover docs * docs: add block builder data structure * docs: update block builder * docs: add withdrawal server docs * docs: add validity prover worker tasks * docs: delete legacy store vault server * docs: add pruning docs * docs: update validity prover docs * docs: update * docs: interface * docs: add Troubleshooting * fix: add membership verification during `add_signature` (#465) * fix: add membership verification during add_signature to prevent future panic * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: typo for ci --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add rate limit & reduce max batch size (#464) * feat: add rate limit & reduce max batch size * feat: use wasm time * feat: longer rate limit * feat: remove AGENTS.md * fix: typo * Retry 502 error (#470) --------- Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com> * fix(client): consume only invalid (#473) --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> Co-authored-by: signature18632 <intmax18@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.