Skip to content

Comments

feat: Integrated gnark#448

Merged
kbizikav merged 7 commits intodevfrom
integrated-gnark
Aug 12, 2025
Merged

feat: Integrated gnark#448
kbizikav merged 7 commits intodevfrom
integrated-gnark

Conversation

@kbizikav
Copy link
Collaborator

@kbizikav kbizikav commented Aug 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 4, 2025 10:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates gnark by refactoring the circuit verification system to remove circuit-specific configurations and unify the implementation. The changes consolidate multiple circuit data directories into a single configuration and introduce a new input digest calculation mechanism for enhanced verification.

  • Consolidates circuit-specific data directories into a unified data structure
  • Introduces input digest calculation for public inputs validation
  • Removes circuit name parameters from initialization and execution flows

Reviewed Changes

Copilot reviewed 16 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
job-servers/gnark-server/utils/pis.go Adds new CalculateInputDigest function for validating and computing digest of 8 public inputs
job-servers/gnark-server/setup/main.go Removes circuit name parameter and updates paths to use unified data directory
job-servers/gnark-server/main.go Removes circuit name flag and simplifies initialization
job-servers/gnark-server/handlers/prove.go Updates prove handler to accept verifier data and use new input digest calculation
job-servers/gnark-server/circuit/verifierCircuit.go Refactors circuit structure to use new digest validation and public input verification
job-servers/gnark-server/circuitData/circuitData.go Simplifies circuit data loading by removing circuit-specific paths
Various data files Removes circuit-specific directories and adds unified test data
Cargo.toml files Updates dependency branch to "dev"
Comments suppressed due to low confidence (1)

job-servers/gnark-server/handlers/prove.go:68

  • [nitpick] The parameter name vdRaw is unclear. Consider renaming it to verifierDataRaw for better readability.
func (s *State) prove(jobId string, proofRaw types.ProofWithPublicInputsRaw, vdRaw types.VerifierOnlyCircuitDataRaw) error {

@kbizikav kbizikav merged commit 4e86abd into dev Aug 12, 2025
5 checks passed
@kbizikav kbizikav deleted the integrated-gnark branch August 12, 2025 03:55
signature18632 pushed a commit that referenced this pull request Aug 16, 2025
* feat: Integrated gnark (#448)

* chore: update intmax2-zkp deps

* feat: delete circuit dependency

* feat: add some data

* docs: update readme & testdata

* chore: update proof

* chore: fix limb error

* Single history status (#453)

* feat: entry status replace

* feat: wip strategy replacement

* feat: impl seperate group

* feat: optional cursor

* feat: impl fetch batch

* feat: impl fetch batch wasm

---------

Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com>

---------

Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com>
signature18632 added a commit that referenced this pull request Oct 31, 2025
* feat: Integrated gnark (#448)

* chore: update intmax2-zkp deps

* feat: delete circuit dependency

* feat: add some data

* docs: update readme & testdata

* chore: update proof

* chore: fix limb error

* Single history status (#453)

* feat: entry status replace

* feat: wip strategy replacement

* feat: impl seperate group

* feat: optional cursor

* feat: impl fetch batch

* feat: impl fetch batch wasm

---------

Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com>

* change os (#458)

* feat: add get used memo func for wasm (#469)

* feat: add get used memo func for wasm

* fix: fix typo for ci

* docs: added comprehensive docs for all nodes (#446)

* chore: update docs

* docs: add block builder docs

* docs: add balance prover readme

* docs: client sdk

* docs: fix client sdk docs

* docs: add validity prover docs

* docs: add block builder data structure

* docs: update block builder

* docs: add withdrawal server docs

* docs: add validity prover worker tasks

* docs: delete legacy store vault server

* docs: add pruning docs

* docs: update validity prover docs

* docs: update

* docs: interface

* docs: add Troubleshooting

* fix: add membership verification during `add_signature` (#465)

* fix: add membership verification during add_signature to prevent future panic

* Update block-builder/src/app/storage/memory_storage.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update block-builder/src/app/storage/memory_storage.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: typo for ci

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat: add rate limit & reduce max batch size (#464)

* feat: add rate limit & reduce max batch size

* feat: use wasm time

* feat: longer rate limit

* feat: remove AGENTS.md

* fix: typo

* Retry 502 error (#470)

---------

Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com>

---------

Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com>
Co-authored-by: signature18632 <intmax18@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
signature18632 added a commit that referenced this pull request Nov 13, 2025
* feat: Integrated gnark (#448)

* chore: update intmax2-zkp deps

* feat: delete circuit dependency

* feat: add some data

* docs: update readme & testdata

* chore: update proof

* chore: fix limb error

* Single history status (#453)

* feat: entry status replace

* feat: wip strategy replacement

* feat: impl seperate group

* feat: optional cursor

* feat: impl fetch batch

* feat: impl fetch batch wasm

---------

Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com>

* change os (#458)

* feat: add get used memo func for wasm (#469)

* feat: add get used memo func for wasm

* fix: fix typo for ci

* docs: added comprehensive docs for all nodes (#446)

* chore: update docs

* docs: add block builder docs

* docs: add balance prover readme

* docs: client sdk

* docs: fix client sdk docs

* docs: add validity prover docs

* docs: add block builder data structure

* docs: update block builder

* docs: add withdrawal server docs

* docs: add validity prover worker tasks

* docs: delete legacy store vault server

* docs: add pruning docs

* docs: update validity prover docs

* docs: update

* docs: interface

* docs: add Troubleshooting

* fix: add membership verification during `add_signature` (#465)

* fix: add membership verification during add_signature to prevent future panic

* Update block-builder/src/app/storage/memory_storage.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update block-builder/src/app/storage/memory_storage.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: typo for ci

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat: add rate limit & reduce max batch size (#464)

* feat: add rate limit & reduce max batch size

* feat: use wasm time

* feat: longer rate limit

* feat: remove AGENTS.md

* fix: typo

* Retry 502 error (#470)

---------

Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com>

* fix(client): consume only invalid (#473)

---------

Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com>
Co-authored-by: signature18632 <intmax18@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants