backport port chatbox utf8 support to 1.19.2 #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds optional "useUtf8" parameter, informing us that the program is utf8 aware, providing its strings as utf8,
This allows sending messages in the extended minecraft character set.
see the utf8 lib in cc, as well as the \u{xxxx} escape sequence.
also sends the events with a new utf8 message parameter.
This is a backport from IntelligenceModding#757
zyxkad
requested changes
Jul 1, 2025
.../de/srendi/advancedperipherals/common/addons/computercraft/peripheral/ChatBoxPeripheral.java
Outdated
Show resolved
Hide resolved
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
zyxkad
reviewed
Jul 1, 2025
| @@ -349,11 +417,18 @@ public final MethodResult sendFormattedMessageToPlayer(@NotNull IArguments argum | |||
| } | |||
|
|
|||
|
|
|||
| // 0 message, 1 title, 2 playerName, 3 prefix, 4 brackets, 5 bracket color, 6 range, 7 utf8compatible | |||
There was a problem hiding this comment.
In 0.8 we must use a keyword table argument instead of the long long argument list :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #757 to 1.19.2
adds optional "useUtf8" parameter, informing us that the program is utf8 aware, providing its strings as utf8,
This allows sending messages in the extended minecraft character set.
see the utf8 lib in cc, as well as the \u{xxxx} escape sequence.
also sends the events with a new utf8 message parameter.