add utf8 message support to chatboxes #757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds optional "useUtf8" parameter, informing us that the program is utf8 aware, providing its strings as utf8, This allows sending messages in the extended minecraft character set.
see the utf8 lib in cc, as well as the \u{xxxx} escape sequence.
also sends the events with a new utf8 message parameter.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

utf8 message is provided as argument 5 (the current last one)
NO: this behaviour is opt in as a default-false optional parameter to all messagebox methods.
if users with to take advantage of this behaviour when sending messages, they should set the (current) last parameter to true
unless they are relying on specific parameter counts / not having extra data in the event, but thats not a breaking change for 99%, just 1 case of spacebar heating