fix: we should just always clone the region in ApplyTask #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Jul 25, 2025
dordsor21
commented
- fixes //sel polyhedral broken #3231
NotMyFault
approved these changes
Jul 25, 2025
SirYwell
approved these changes
Jul 28, 2025
Member
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
A bit sad that we actually have Region implementations mutating during contains checks, but I guess we can live with that.
PierreSchwang
approved these changes
Jul 28, 2025
Member
Author
It probably does make a somewhat meaningful difference for the Poly*Region implementations... When they are very large |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.