Skip to content

Fix offset mask mutating vector #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SirYwell merged 1 commit into from
Mar 6, 2025
Merged

Fix offset mask mutating vector #3135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions worldedit-core/src/main/java/com/sk89q/worldedit/function/mask/OffsetMask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package com.sk89q.worldedit.function.mask;

import com.fastasyncworldedit.core.math.MutableBlockVector3;
import com.sk89q.worldedit.WorldEdit;
import com.sk89q.worldedit.extension.platform.Capability;
import com.sk89q.worldedit.math.BlockVector3;
Expand Down Expand Up @@ -115,6 +116,10 @@ public void setOffset(BlockVector3 offset) {
@Override
public boolean test(BlockVector3 vector) {
//FAWE start - ignore resultant position outside world height range
if (vector instanceof MutableBlockVector3) {
// make sure we don't modify a vector passed from the outside
vector = vector.toImmutable();
}
BlockVector3 testPos = vector.add(offset);
if (testPos.y() < minY || testPos.y() > maxY) {
return false;
Expand Down
Loading