Skip to content

Conversation

@SirYwell
Copy link
Member

@SirYwell SirYwell commented Mar 4, 2025

Overview

Fixes #3134

Description

ForwardCopyExtent uses a MutableVector3, and our current OffsetMask implementation modifies it. That results in applying the following function (and potentially other masks) to the wrong block.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner March 4, 2025 19:16
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 4, 2025
@dordsor21 dordsor21 requested a review from a team March 5, 2025 19:37
@SirYwell SirYwell merged commit c8c6484 into main Mar 6, 2025
9 checks passed
@SirYwell SirYwell deleted the fix/offset-mutating-vector branch March 6, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//copy -m mask argflag doesn't work with certain masks

4 participants