Skip to content

Conversation

@SirYwell
Copy link
Member

Overview

Description

We can reduce some code duplication by moving the fields that don't require a version-dependent type to the superclass.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner October 28, 2024 16:11
@github-actions github-actions bot added the chore label Oct 28, 2024
@dordsor21 dordsor21 requested a review from a team October 28, 2024 21:16
@dordsor21 dordsor21 merged commit bd94632 into main Nov 4, 2024
@dordsor21 dordsor21 deleted the refactor/fawe-adapter-fields branch November 4, 2024 11:21
@SirYwell SirYwell mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants