Skip to content

Conversation

@PierreSchwang
Copy link
Member

Overview

1.21.3 support

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@github-actions github-actions bot added the Feature This PR adds a new feature label Nov 1, 2024
@PierreSchwang
Copy link
Member Author

No issues so far, everything I've tested works as expected (property tab complete, masking, regen, modifying selections). Not sure if we want to add the new (1.21.4) block types and stuff as well (just like WE does in their 1.21.3 draft PR) or release 1.21.3 as is

Copy link
Member

@dordsor21 dordsor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth going for 1.20.3 first and then adding the .4 stuff as necessary

@PierreSchwang PierreSchwang marked this pull request as ready for review November 4, 2024 07:40
@PierreSchwang PierreSchwang requested a review from a team as a code owner November 4, 2024 07:40
@SirYwell
Copy link
Member

SirYwell commented Nov 6, 2024

I noticed that the versions are somewhat inconsistent. We currently support 1.20.2, 1.20.4, 1.20.6, 1.21.1, and 1.21.3, right?

Could you also update the issue template?

@PierreSchwang
Copy link
Member Author

I noticed that the versions are somewhat inconsistent. We currently support 1.20.2, 1.20.4, 1.20.6, 1.21.1, and 1.21.3, right?

Could you also update the issue template?

The versions are pulled from the actual versions supported by our adapters:
1_20_2 -> 1.20.2
1_20_4 -> 1.20.3, 1.20.4
1_20_5 -> 1.20.5, 1.20.6
1_21 -> 1.21, 1.21.1
1_21_3 -> 1.21.3

@SirYwell
Copy link
Member

SirYwell commented Nov 8, 2024

The versions are pulled from the actual versions supported by our adapters:
1_20_2 -> 1.20.2
1_20_4 -> 1.20.3, 1.20.4
1_20_5 -> 1.20.5, 1.20.6
1_21 -> 1.21, 1.21.1
1_21_3 -> 1.21.3

Yes, but e.g. https://github.com/IntellectualSites/FastAsyncWorldEdit/pull/2974/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R86 doesn't mention 1.20.2 (but 1.20.5, which is covered by 1.20.6 basically), and the issue template is not up to date.

@PierreSchwang
Copy link
Member Author

The versions are pulled from the actual versions supported by our adapters:
1_20_2 -> 1.20.2
1_20_4 -> 1.20.3, 1.20.4
1_20_5 -> 1.20.5, 1.20.6
1_21 -> 1.21, 1.21.1
1_21_3 -> 1.21.3

Yes, but e.g. https://github.com/IntellectualSites/FastAsyncWorldEdit/pull/2974/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R86 doesn't mention 1.20.2 (but 1.20.5, which is covered by 1.20.6 basically), and the issue template is not up to date.

I guess we could restrict supported versions to something like 1.20.4, 1.20.6, 1.21.1 & 1.21.3? would make the list more compact and skips a few updates which are not that widely used, I guess?

@SirYwell
Copy link
Member

SirYwell commented Nov 8, 2024

I guess we could restrict supported versions to something like 1.20.4, 1.20.6, 1.21.1 & 1.21.3? would make the list more compact and skips a few updates which are not that widely used, I guess?

Yes, 1.20.2 should be added still, but otherwise just the latest version supported by the specific adapter version I guess.

@dordsor21 dordsor21 merged commit ef84264 into main Nov 10, 2024
@dordsor21 dordsor21 deleted the feat/1.21.3 branch November 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature This PR adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants