Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround to prevent crash on Windows in internal CI/CD #2062

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Add workaround to prevent crash on Windows in internal CI/CD #2062

merged 4 commits into from
Sep 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 18, 2024 •
edited
Loading

The PR implements a temporary workaround to prevent crash in dpnp tests on Windows in internal CI/CD jobs (when running on either Lunar Lake or Arrow Lake machine).
The w/a has to be removed once the issue is resolved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit b4a1eca into master Sep 19, 2024
42 of 46 checks passed
@antonwolfy antonwolfy deleted the wa-to-avoid-crash-on-win branch September 19, 2024 10:24
antonwolfy added a commit that referenced this pull request Sep 19, 2024
@antonwolfy
Add workaround to prevent crash on Windows in internal CI/CD (#2062)
e68102c 
* Add workaround to prevent crash on Windows in internal CI/CD

* Updated changellog

* Aplied the w/a to test_random
@antonwolfy antonwolfy mentioned this pull request Sep 19, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 19, 2024
@github-actions
Add workaround to prevent crash on Windows in internal CI/CD (#2062)
0eca6eb 
* Add workaround to prevent crash on Windows in internal CI/CD

* Updated changellog

* Aplied the w/a to test_random b4a1eca
github-actions bot added a commit that referenced this pull request Sep 19, 2024
@github-actions
Backport gh-2062 a45c811
fd40122
antonwolfy added a commit that referenced this pull request Sep 19, 2024
@antonwolfy
Add workaround to prevent crash on Windows in internal CI/CD (#2062) (#…
377179a 
…2065)

* Add workaround to prevent crash on Windows in internal CI/CD

* Updated changellog

* Aplied the w/a to test_random
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana