Skip to content

Commit

Permalink
Add workaround to prevent crash on Windows in internal CI/CD (#2062) (#…
Browse files Browse the repository at this point in the history
…2065)

* Add workaround to prevent crash on Windows in internal CI/CD

* Updated changellog

* Aplied the w/a to test_random
  • Loading branch information
antonwolfy authored Sep 19, 2024
1 parent 7add8ff commit 377179a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ In addition, this release completes implementation of `dpnp.fft` module and adds
* Resolved a possible race condition in `dpnp.inv` [#1940](https://github.com/IntelPython/dpnp/pull/1940)
* Resolved an issue with failing tests for `dpnp.append` when running on a device without fp64 support [#2034](https://github.com/IntelPython/dpnp/pull/2034)
* Resolved an issue with input array of `usm_ndarray` passed into `dpnp.ix_` [#2047](https://github.com/IntelPython/dpnp/pull/2047)
* Added a workaround to prevent crash in tests on Windows in internal CI/CD (when running on either Lunar Lake or Arrow Lake) [#2062](https://github.com/IntelPython/dpnp/pull/2062)


## [0.15.0] - 05/25/2024
Expand Down
10 changes: 8 additions & 2 deletions tests/test_sycl_queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,10 @@ def test_random(func, kwargs, device, usm_type):
assert device == res_array.sycl_device
assert usm_type == res_array.usm_type

sycl_queue = dpctl.SyclQueue(device, property="in_order")
# SAT-7414: w/a to avoid crash on Windows (observing on LNL and ARL)
# sycl_queue = dpctl.SyclQueue(device, property="in_order")
# TODO: remove the w/a once resolved
sycl_queue = dpctl.SyclQueue(device, property="enable_profiling")
kwargs["device"] = None
kwargs["sycl_queue"] = sycl_queue

Expand Down Expand Up @@ -1075,7 +1078,10 @@ def test_random_state(func, args, kwargs, device, usm_type):
assert device == res_array.sycl_device
assert usm_type == res_array.usm_type

sycl_queue = dpctl.SyclQueue(device, property="in_order")
# SAT-7414: w/a to avoid crash on Windows (observing on LNL and ARL)
# sycl_queue = dpctl.SyclQueue(device, property="in_order")
# TODO: remove the w/a once resolved
sycl_queue = dpctl.SyclQueue(device, property="enable_profiling")

# test with in-order SYCL queue per a device and passed as argument
seed = (147, 56, 896) if device.is_cpu else 987654
Expand Down

0 comments on commit 377179a

Please sign in to comment.