Fix failing test for dpnp.append when no fp64 for device
#2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
approved these changes
Sep 14, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 14, 2024
* Fix test for dpnp.append with was failing with no fp64 support * Update docstring for dpnp.append and dpnp.asarray_chkfinite --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 1cba68c
antonwolfy
added a commit
that referenced
this pull request
Sep 14, 2024
* Fix test for dpnp.append with was failing with no fp64 support * Update docstring for dpnp.append and dpnp.asarray_chkfinite --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
This was referenced Sep 14, 2024
Merged
antonwolfy
added a commit
that referenced
this pull request
Sep 16, 2024
* Fix failing test for `dpnp.append` when no fp64 for device (#2034) * Fix test for dpnp.append with was failing with no fp64 support * Update docstring for dpnp.append and dpnp.asarray_chkfinite --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> * Update CHANGELOG --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
antonwolfy
added a commit
that referenced
this pull request
Sep 16, 2024
* Fix failing test for `dpnp.append` when no fp64 for device (#2034) * Fix test for dpnp.append with was failing with no fp64 support * Update docstring for dpnp.append and dpnp.asarray_chkfinite --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> * Update CHANGELOG * Use Pybind11 2.13.6 to build dpnp (#2041) Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> * Update CHANGELOG --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
antonwolfy
added a commit
that referenced
this pull request
Sep 16, 2024
* Fix failing test for `dpnp.append` when no fp64 for device (#2034) * Fix test for dpnp.append with was failing with no fp64 support * Update docstring for dpnp.append and dpnp.asarray_chkfinite --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> * Update CHANGELOG * Use Pybind11 2.13.6 to build dpnp (#2041) Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> * Update CHANGELOG * Use `INTEL_MKL_VERSION` flag (#2035) * use MKL_VERSION flag * update CHANGELOG.md * Backport gh-2030 (#2046) * Implement `dpnp.rot90` and `dpnp.resize` (#2030) * add rot90 and resize * fix docstring * address comments --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> * Update changelog --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to implement a fix for test from
tests/third_party/cupy/manipulation_tests/test_add_remove.pyscope failing with a device without fp64 support.Additionally formatting issues in description of
dpnp.appendanddpnp.asarray_chkfinitewere resolved anddpnp.asarray_chkfinitewas moved indpnp/dpnp_iface_manipulation.pyfile to keep lexicographical order.