Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.rot90 and dpnp.resize #2030

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Implement dpnp.rot90 and dpnp.resize #2030

merged 6 commits into from
Sep 15, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 12, 2024

In this PR, dpnp.rot90 and dpnp.resize are implemented.
Note that the dpnp.ndarray.resize behaves different than dpnp.resize and will be addressed separately.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 13, 2024 16:59
antonwolfy
antonwolfy reviewed Sep 14, 2024
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/test_manipulation.py Outdated Show resolved Hide resolved
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
tests/test_usm_type.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy merged commit 22b1c73 into master Sep 15, 2024
37 of 46 checks passed
@antonwolfy antonwolfy deleted the resize_rot90 branch September 15, 2024 08:56
antonwolfy added a commit that referenced this pull request Sep 15, 2024
@antonwolfy
Added gh-2030 entry to changelog
dc3a012
@antonwolfy antonwolfy mentioned this pull request Sep 15, 2024
Merged
6 tasks
antonwolfy added a commit that referenced this pull request Sep 15, 2024
@vtavana @antonwolfy
Implement dpnp.rot90 and dpnp.resize (#2030)
b2661f6 
* add rot90 and resize

* fix docstring

* address comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@antonwolfy antonwolfy mentioned this pull request Sep 15, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 15, 2024
@github-actions
Implement dpnp.rot90 and dpnp.resize (#2030)
53dcbfe 
* add rot90 and resize

* fix docstring

* address comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 22b1c73
github-actions bot added a commit that referenced this pull request Sep 15, 2024
@github-actions
Backport gh-2030 091bc9e
0f7a028
vtavana pushed a commit that referenced this pull request Sep 15, 2024
@antonwolfy
Update changelog with backported gh-2041 and gh-2030 (#2044)
be5c3f0 
* Update Changelog

* Added gh-2030 entry to changelog
vtavana added a commit that referenced this pull request Sep 15, 2024
@antonwolfy @vtavana
Backport gh-2030 (#2046)
de8298c 
* Implement `dpnp.rot90` and `dpnp.resize` (#2030)

* add rot90 and resize

* fix docstring

* address comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

* Update changelog

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Sep 15, 2024
@github-actions
Update changelog with backported gh-2041 and gh-2030 (#2044)
0b447c8 
* Update Changelog

* Added gh-2030 entry to changelog be5c3f0
antonwolfy added a commit that referenced this pull request Sep 16, 2024
@antonwolfy @vtavana
Backport gh-2035 (#2045)
e309ebf 
* Fix failing test for `dpnp.append` when no fp64 for device (#2034)

* Fix test for dpnp.append with was failing with no fp64 support

* Update docstring for dpnp.append and dpnp.asarray_chkfinite

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

* Update CHANGELOG

* Use Pybind11 2.13.6 to build dpnp (#2041)

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

* Update CHANGELOG

* Use `INTEL_MKL_VERSION` flag (#2035)

* use MKL_VERSION flag

* update CHANGELOG.md

* Backport gh-2030 (#2046)

* Implement `dpnp.rot90` and `dpnp.resize` (#2030)

* add rot90 and resize

* fix docstring

* address comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

* Update changelog

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy