Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dpnp.linalg.solve() hang on CPU #1778

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds a workaround for solving dpnp.linalg.solve() hang issue for batch implementation on CPU as adding wait() for each host task before calling MKL function (gesv) in the loop.
This is a known issue and was addressed to MKL team.

Also this PR unlocks skipped tests added in #1762

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Apr 8, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vlad-perevezentsev vlad-perevezentsev self-assigned this Apr 9, 2024
@vlad-perevezentsev vlad-perevezentsev merged commit ffc5429 into master Apr 11, 2024
56 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the fix_solve_public_ci branch April 11, 2024 13:14
github-actions bot added a commit that referenced this pull request Apr 11, 2024
* Add wait() for each ht_lapack_ev(gesv) in loop on CPU

* Add wait() for each b_ht_copy_ev in the loop ffc5429
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 12, 2024
* Add wait() for each ht_lapack_ev(gesv) in loop on CPU

* Add wait() for each b_ht_copy_ev in the loop ffc5429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants