Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary mute tests for dpnp.solve #1762

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Temporary mute tests for dpnp.solve #1762

merged 5 commits into from
Mar 28, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 28, 2024 •
edited
Loading

The PR proposes to temporary mute tests in public CI which causes hanging until the issue is resolved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 9872abc into master Mar 28, 2024
42 of 45 checks passed
@antonwolfy antonwolfy deleted the mute-solve-tests-in-public-ci branch March 28, 2024 17:04
github-actions bot added a commit that referenced this pull request Mar 28, 2024
@github-actions
Temporary mute tests for dpnp.solve (#1762)
9249fdd 
* Temporary mute tests for dpnp.solve

* Corrected the mute condition

* Update tests/third_party/cupy/linalg_tests/test_solve.py

* Update tests/third_party/cupy/linalg_tests/test_solve.py

* Moved skip mark to a proper call 9872abc
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Mar 28, 2024
@github-actions
Temporary mute tests for dpnp.solve (IntelPython#1762)
b42e9e9 
* Temporary mute tests for dpnp.solve

* Corrected the mute condition

* Update tests/third_party/cupy/linalg_tests/test_solve.py

* Update tests/third_party/cupy/linalg_tests/test_solve.py

* Moved skip mark to a proper call 9872abc
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Apr 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev