Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of DPCTLSyclInterface function was deprecated in #876, and
__attributes__((deprecated(what, repl))
was used.This broke building of C extensions using the library. This PR uses
[[deprecated(msg)]]
instead, which is understood by both the gcc and icx.An example of native Python extension written in C and that is using DPCTLSyclInterface is added. It is being compiled in the workflow
conda-package.yml
workflow when testing that examples can be compiled on Linux.Incidentally,
dpctl.lsplatform
implementation replaced informationalprint
with seemingly more appropriate use ofwarnings.warn
.@mingjie-intel