Skip to content

Turn off SO versioning for release 0.8 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented May 25, 2021

The issue is that conda-build would turn symbolic links of version
library shared objects into hard copies.

Downstream project (e.g. numba-dppy) may end up loading different
hard copies of the library and thus maintain different global states
and encounter segfaults from discrepancies in these states

The issue is that conda-build would turn symbolic links of version
library shared objects into hard copies.

Downstream project (e.g. numba-dppy) may end up loading different
hard copies of the library and thus maintain different global states
and encounter seg-faults from descrepancies in these states
@oleksandr-pavlyk oleksandr-pavlyk merged commit 414f0a6 into master May 25, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the hotfix/revert-so-versioning branch May 25, 2021 18:43
@tomashek
Copy link

@oleksandr-pavlyk , conda-build definitely supports symlinks for Linux, and we are supposed to have so versioning. Where did you see this problem?

@oleksandr-pavlyk
Copy link
Contributor Author

@tomashek Building dpctl using conda-build does that (look at lib/libDPCTLSyclInterface.so* files in the conda tar ball)

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 60.665% when pulling 71f896a on hotfix/revert-so-versioning into 27634ef on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants