Skip to content

Commit 414f0a6

Browse files
Turn off SO versioning for release 0.8 (#470)
The issue is that conda-build would turn symbolic links of version library shared objects into hard copies. Downstream project (e.g. numba-dppy) may end up loading different hard copies of the library and thus maintain different global states and encounter seg-faults from descrepancies in these states
1 parent 27634ef commit 414f0a6

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

dpctl-capi/CMakeLists.txt

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,14 @@
11
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
22

3-
# Load our CMake modules to search for DPCPP and Level Zero
4-
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/modules/")
5-
find_package(Git REQUIRED)
6-
include(GetProjectVersion)
7-
# the get_version function is defined in the GetProjectVersion module and
8-
# defines: VERSION, SEMVER, MAJOR, MINOR, PATCH. These variables are populated
9-
# by parsing the output of git describe.
10-
get_version()
113
project(
124
"libDPCTLSYCLInterface"
135
DESCRIPTION "A C API for a subset of SYCL"
146
)
157

8+
# Load our CMake modules to search for DPCPP and Level Zero
9+
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/modules/")
10+
find_package(Git REQUIRED)
11+
1612
option(DPCTL_CUSTOM_DPCPP_INSTALL_DIR
1713
"Use a custom version of DPCPP installed at the provided location."
1814
OFF
@@ -158,10 +154,16 @@ if(DPCTL_ENABLE_LO_PROGRAM_CREATION)
158154
)
159155
endif()
160156

157+
# FIXME: Turning off for release until conda build can be packaging symbolic links
161158
# NOTE: Till we hit 1.0.0 we will keep using the MINOR version to set the API
162159
# version of the library.
163-
set_target_properties(DPCTLSyclInterface PROPERTIES VERSION ${VERSION_MINOR})
164-
set_target_properties(DPCTLSyclInterface PROPERTIES SOVERSION 1)
160+
# include(GetProjectVersion)
161+
# the get_version function is defined in the GetProjectVersion module and
162+
# defines: VERSION, SEMVER, MAJOR, MINOR, PATCH. These variables are populated
163+
# by parsing the output of git describe.
164+
# get_version()
165+
# set_target_properties(DPCTLSyclInterface PROPERTIES VERSION ${VERSION_MINOR})
166+
# set_target_properties(DPCTLSyclInterface PROPERTIES SOVERSION 1)
165167

166168
install(TARGETS
167169
DPCTLSyclInterface

0 commit comments

Comments
 (0)