Skip to content

Add a version requirement for dpcpp inside CMakeList.txt. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2021
Merged

Add a version requirement for dpcpp inside CMakeList.txt. #339

merged 2 commits into from
Apr 2, 2021

Conversation

diptorupd
Copy link
Contributor

No description provided.

@diptorupd diptorupd marked this pull request as draft March 28, 2021 15:50
@diptorupd
Copy link
Contributor Author

diptorupd commented Mar 28, 2021 •
edited
Loading

@oleksandr-pavlyk There are two more things that we need to properly address before this is ready to be merged:

  1. The dpcpp_cpp_rt package used at runtime and the dpcpp compiler used to compile should be made to match.
  2. C API build script improvements to build dpctl with a custom DPC++ and other changes #319 (using a custom dpcpp) will not work with this PR as open source dpcpp does not use same version scheme as oneAPI dpcpp.

@diptorupd diptorupd requested a review from PokhodenkoSA March 31, 2021 03:20
@diptorupd diptorupd marked this pull request as ready for review March 31, 2021 03:21
@oleksandr-pavlyk
Copy link
Contributor

The cmake 3.20 supports oneAPI compiler as IntelLLVM, see New In 3.20#Compilers.

Perhaps this could be leveraged to support both custom build of open-source LLVM with SYCL support and dpcpp.

We can also institute a shallow dpctl init-time check that the DCPPP run-time meets functional requirements, i.e. can ascertain that two devices created with the same selector are equal, and raise RuntimeError otherwise.

@diptorupd diptorupd merged commit 8be34ec into IntelPython:master Apr 2, 2021
@diptorupd diptorupd deleted the specify_dpcpp_version_reqs branch April 2, 2021 16:02
diptorupd pushed a commit to diptorupd/dpctl that referenced this pull request Apr 2, 2021
Add a version requirement for dpcpp inside CMakeList.txt. (IntelPytho…
accabac 
…n#339)

* Add a version requirement for dpcpp inside CMakeList.txt.

* Add dpcpp_cpp_rt version requirement to dpctl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diptorupd @oleksandr-pavlyk