Skip to content

Fix inconsistency system git and conda env #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

Using system git in conda environment may be problematic due to inconsistency in dependent libraries.

For example, #1000 and #999 were affected by this:

03:35:37.053600 git.c:460               trace: built-in: git clone https://github.com/oneapi-src/level-zero.git
Cloning into 'level-zero'...
03:35:37.060849 run-command.c:655       trace: run_command: git remote-https origin https://github.com/oneapi-src/level-zero.git
03:35:37.063415 git.c:750               trace: exec: git-remote-https origin https://github.com/oneapi-src/level-zero.git
03:35:37.063456 run-command.c:655       trace: run_command: git-remote-https origin https://github.com/oneapi-src/level-zero.git
/usr/lib/git-core/git-remote-https: symbol lookup error: /lib/x86_64-linux-gnu/libp11-kit.so.0: undefined symbol: ffi_type_pointer, version LIBFFI_BASE_7.0

This library version mismatch caused git to silently return with status code 128, and took using GIT_TRACE=true to pin-point the cause.

This PR:

  • add git to conda host environment

  • Expands fatal error messages after execute_process to output process return code

  • avoid calling to setup.py clean in build.sh if _skbuild/ folder does not exist

  • Have you provided a meaningful PR description?

  • Have you added a test, reproducer or referred to an issue with a reproducer?

  • Have you tested your changes locally for CPU and GPU devices?

  • Have you made sure that new changes do not introduce compiler warnings?

This avoids situations where system git's library dependency are picked
up from conda environment and being inconsistent (may cause GIT to exit
with code 128, internal error).
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 81.999% when pulling 701f708 on fix-inconsistency-system-git-and-conda-env into 7690952 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_10 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 457450a into master Nov 28, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-inconsistency-system-git-and-conda-env branch November 28, 2022 13:39
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_10 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants