Fix inconsistency system git and conda env #1001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using system
git
in conda environment may be problematic due to inconsistency in dependent libraries.For example, #1000 and #999 were affected by this:
This library version mismatch caused git to silently return with status code 128, and took using
GIT_TRACE=true
to pin-point the cause.This PR:
add
git
to conda host environmentExpands fatal error messages after
execute_process
to output process return codeavoid calling to
setup.py clean
inbuild.sh
if_skbuild/
folder does not existHave you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?