Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

dpctl_capi ctor initialize all members, dtor resets smart pointers

This addressed accessing uninitialized variables SDL tool warnings.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Nov 25, 2022

Coverage Status

Coverage remained the same at 81.999% when pulling 0942321 on dpctl_api-ctor-dtor into 457450a on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the dpctl_api-ctor-dtor branch 12 times, most recently from 19b1a52 to 31215e6 Compare November 28, 2022 12:35
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_10 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_12 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

This addressed accessing uninitialized variables SDL tool warnings.
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_12 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Copy link
Contributor Author

Additional scan of this PR by the tool confirmed that access of uninitialized variable warnings and memory leak warnings are gone.

@oleksandr-pavlyk oleksandr-pavlyk merged commit a2edadb into master Nov 29, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the dpctl_api-ctor-dtor branch November 29, 2022 03:19
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_16 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants