Feat/sync with official repo #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added Brave bidder adapter with test and docs Commit has standard bidder adapter 2 new files adapter js, adapter md * added test spec file witch covered code least 80 % * adding videoHeroes bidder adapter * added videoHeroes test spec * Update braveBidAdapter.js * Update braveBidAdapter.js * Update videoheroesBidAdapter.md * upd import of utils lib to load only certain fnc
* Remove window reference * Changed version to string
* Adapter does not seem capable of supporting advertiserDomains prebid#6650 added response comment and some trivial code. * removed a blank line at the end of file added a space behind the // in comments * in response to comment from reviewer. add the aspect of advertiserdomain in unit tests * added the code to get the keywords from the meta tags if available. * jixie sending schain info to jixie backend * support of schain info sent to jixie endpoint, fixing some indentation complaints from auto build check
* gravitompId user module for integrating gravito first party cookie with prebid js * fixed eslint issues raised by circleci * fixed trailing spaces error raised by circleci
…ebid#8284) * Fixed bugs on rtd module and added the entropy values required by Akamai DAP * Fixed the timeout issue in build browserstack tests * Fixing review comments * Fixing review comments - using storage manager for managing localStorage * Fixing review comments - using loadExternalScript method to load the script * Fixed unit test case * Fixing review comments - Added consent handling
* zeta_global_sspBidAdapter shortname was added * remove the trash Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>
…lues (prebid#8284)" (prebid#8464) This reverts commit c434889.
…ll be used (prebid#8473) Co-authored-by: Jason Lydon <jason.lydon@flashtalking.com>
* Novatiq snowflake userId submodule Novatiq snowflake userId submodule initial release * change request updates added novatiq info /modules/userId/userId.md added novatiq info /modules/userId/eids.md added novatiq eids /modules/userId/eids.js added novatiq module in /modules/.submodules.json removed unnecessary value from getId response * Update novatiqIdSystem_spec.js removed unnecessary srcid value * Update novatiqIdSystem.md Novatiq ID System: updated novatiq snowflake ID description * use the sharedId if available and configured * updated docs * test changes * defensive code not required * Use the prebid storage manager instead of using native functions * doc changes * trailing spaces * Allow configuration of the sync URL and to allow callbacks for specific custom partner integrations * update documentation * attempt to fix firefox test timeout * include the AIB Vendor Id Co-authored-by: novatiq <79258366+novatiq@users.noreply.github.com>
…for XHR mock race conditions (prebid#8466) * Datablocks bid adapter: do not send metrics during tests * Log contents of XHR mock on test failure * Disable ajax for analytics adapters during tests * Do not assume that test setup did not fail
* Adloox Analytics: use CSS.escape when possible * Adloox Analytics/RTD: support GPID
…ebid#8470) * Fixed bugs on rtd module and added the entropy values required by Akamai DAP * Fixed the timeout issue in build browserstack tests * Fixing review comments * Fixing review comments - using storage manager for managing localStorage * Fixing review comments - using loadExternalScript method to load the script * Fixed unit test case * Fixing review comments - Added consent handling
* feat: [EX-3265] format tests for prebid.js adapter * feat: [EX-3265] add tests for video media type * feat: [EX-3265] fix test for interpretResponse * feat: [EX-3265] fix test for interpretResponse * feat: [EX-3265] fix test for interpretResponse Co-authored-by: Maxim Pakhomov <maxim_pakhomov@lineate.com> Co-authored-by: Maxim Pakhomov <70204615+maximpakhomov@users.noreply.github.com>
Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>
…8445) * Removed position parameter. * Removed zip parameter. * Removed placementId parameter and make sizes required instead. * Updated price-related macros. * Fixed error when params is not provided. * Removed last occurrence of placementId. * Read currency.adServerCurrency as publisherCurrency. * Use DEV endpoint for testing. * Use config.pageUrl when test is set to true. * Added more details about page URL. * `config.pageUrl`. * Added a comment explaining why pageUrl is considered only when testing. * Fixed double quotes in tests.
…rebid#8441) * fixed regex used to get naveggId from LocalStorage * added unit tests Co-authored-by: Jose <jose.silva@navegg.com>
* create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * add it also to the aftereach * add it also to the aftereach
…alScript (prebid#8432) * JDB-533: replacing appendChild in the ftrack prebid module * JDB-533: working on switching over to AJAX/CDN * JDB-533: removing some commented out code * JDB-533: removing redundant conditions Co-authored-by: Jason Lydon <jason.lydon@flashtalking.com>
* IncrementX Bid Adapter: vertoz adapter renamed to IncrementX * IncrementX Bid Adapter: vertoz adapter renamed to IncrementX - document updated * IncrementX Bid Adapter: vertoz adapter renamed to IncrementX - vertozBidAdapter.md removed Co-authored-by: Mohit Patil <mohitpatil546@gmail.com>
Co-authored-by: monis.q <monis.q@media.net>
* add schain data to the bid request * add unit test with schain data
* ZetaGlobalSsp bid adapter: shortname param into url param * fix tests Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>
…variable names (prebid#8487) * Fixed the randomly failing test cases and updated the variable names * Improving code quality
…hild() to insert the ad tag (prebid#8490)
* Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter * Protocols was added in video section in ad request for TheMediaGrid Bid Adapter * TheMediaGrid: fix trouble with alias using * TheMediaGridNM: fix trouble with alias * TheMediaGrid Bid Adapter: added support of PBAdSlot module * TheMediaGrid Bid Adapter: fix typo * GridNM Bid Adapter: use absent in params data from mediaTypes * GridNM Bid Adapter: fix md file + add advertiserDomains support * TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes * gridNM Bid Adapter updates after review * TheMediaGrid Bid Adapter: fix keywords workflow * fix testing and kick off lgtm again * TheMediaGrid: added ext.bidder.grid.demandSource processing * TheMediaGrid: added user.id from fpd cookie * TheMediaGrid: control cookie setting via bidder config * TheMediaGrid: use localStorage instead cookie * TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint * TheMediaGridNM: fix unnecessary conditions * TheMediaGrid: fix bug with nurl field in response * TheMediaGrid: update test * TheMediaGridNM: fix possible bug with nurl * TheMediaGrid: added alias as playwire * TheMediaGrid: added alias as adlivetech * TheMediaGrid: fix sync url workflow * TrustX: fix sync url worflow + remove old syncurl * TheMediaGrid: added instl support * TheMediaGrid: fix test for instl * TheMediaGrid: update md file * TheMediaGrid: reformat segments for permutive rtd module * TrustX: send all ortb2.user.data in user.data * TheMediaGrid: remove permutive segments reformating * TrustX: remove permutive segments reformating * TheMediaGrid & TrustX: fix typo * TheMediaGrid: support bid.ortb2.site.content * TheMediaGrid Bid Adapter: support bid.ortb2.site.content.id Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
…coding publisher url (prebid#8497)
…ts (prebid#8444) * changes for ajax request options for automatad bid request * add test for isCredentials changes
* Magnite adapters still require legacy GVL IDs * CTV update
* following prebid team's advise * adding to adloader.js * removing generic import
…vider (prebid#8506) Co-authored-by: monis.q <monis.q@media.net>
* Kargo Bid Adapter: Use currency from Bid Response * Kargo Bid Adapter: Fix failed test * Kargo Bid Adapter: adding media type to bid response, supporting vastXml response (prebid#8426) * kargo adapter - adding mediaType to bid response, conditionally set vastXml field * kargo adapter - updating tests * Kargo Bid Adapter: onTimeout Support (#6) * Adding additional param * Adding response time function * Remove debug * Updating response time log to be set by bid response * Adding screen width/height to request * Test fix * Test fix * Removing interpretResponse signaling * Simplifying send data function Co-authored-by: Wei Wong <wwong@kargo.com> Co-authored-by: Andy Rusiecki <andy.rusiecki@gmail.com>
…ebid#8509) Co-authored-by: Timothy M. Ace <tace@imds.tv>
* feat: added support for video * feat: added support for mimes * feat: added mimes check to video validation
…ent should not be enforced for first-party-id modules (prebid#8448) * Fixed issue with gdprEnforcement module and sharedId/pubCommonId modules: vendor consent should not be enforced for first-party-id modules * addressed review comments * addressed review comments * added test to ensure device access is not allowed for vendorless modules in case purpose 1 consent isn't given * fixed issue with missing moduleType param Co-authored-by: Serhii Holdun <sholdun@magnite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.