Multiple adapters: use our tag insertion methods

[patmmccann]

Type of issue

Bug

Description

Several adapters appear to not be using our methods to append scripts or tags to the DOM. Please switch them over

Prebid.js/modules/cleanioRtdProvider.js

Line 58 in 747f143

insertElement(scriptElement);

@nick-clean

Prebid.js/modules/airgridRtdProvider.js

Line 47 in 3ef3cf4

document.getElementsByTagName('head')[0].appendChild(n);

@ydennisy

Prebid.js/modules/realvuAnalyticsAdapter.js

Line 172 in 78e1bdb

a.dv0.appendChild(st);

@tchibirev

[ftxmoJason]

Thanks @patmmccann for pointing this out. Can you direct us to the correct method definition in the docs? Thanks

[patmmccann]

Thanks @patmmccann for pointing this out. Can you direct us to the correct method definition in the docs? Thanks

2a05213 is an example; using the loadExternalScript utility

[patmmccann]

#7699 is an example of a fix to a tag

[parisholley]

@patmmccann we only use that to write image pixels for measuring viewability when the browser does not support the IntersectionObserver API. is there a recommended way to drop non-tracking pixels? loadExternalScript does not seem to be relevant in this case.

[patmmccann]

@parisholley yes please see #7699 as an example

[antlauzon]

@patmmccann we have a fix for this that you should expect to be submitted as a PR soon. Please direct future bugfix requests to @abhibond or @jlaso.

[jimdigriz]

What is the official method to preload a script here?

I cannot find anything obvious:

alex@aineko:~/src/adloox/Prebid.js$ git grep "'preload'" modules/ src/
modules/adlooxAnalyticsAdapter.js:  link.setAttribute('rel', 'preload');
modules/cleanioRtdProvider.js:  linkElement.rel = 'preload';
modules/geoedgeRtdProvider.js:  link.rel = 'preload';

alex@aineko:~/src/adloox/Prebid.js$ git grep '"preload"' modules/ src/
alex@aineko:~/src/adloox/Prebid.js$

The Adloox analytics adapter does already use loadExternalScript, we just want a preload option for it.

[ftxmoJason]

Thanks @patmmccann our fix PR has been merged and closed. We should be all good on this thread, please let us know if we missed anything.

[patmmccann]

@ftxmoJason thanks!

[patmmccann]

@jimdigriz we don't have a preload method. Is it providing some advantage to you to preload the script a couple js dozen lines before you load it? It would seem your preload doesnt run until a couple millisecond before your run.