Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #294 - Support for UIAppearance in IGListCollectionView… #298

Closed
wants to merge 1 commit into from
Closed

Fix for issue #294 - Support for UIAppearance in IGListCollectionView… #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/IGListCollectionView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ @implementation IGListCollectionView

- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout {
if (self = [super initWithFrame:frame collectionViewLayout:layout]) {
self.backgroundColor = [UIColor whiteColor];

UIColor *backgroundAppearanceColor = (UIColor *) [[[self class] appearance] backgroundColor];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can remove this cast

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I had to add the cast to avoid a compile error. At first I didn't have the cast when I had the sample project opened, but when I switched to the IGListKit project I got the following:

Incompatible pointer types initializing 'UIColor *__strong' with an expression of type 'CGColorRef _Nullable' (aka 'struct CGColor *')

if (!backgroundAppearanceColor) {
self.backgroundColor = [UIColor whiteColor];
}

self.alwaysBounceVertical = YES;
}
return self;
Expand Down