-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #294 - Support for UIAppearance in IGListCollectionView… #298
Conversation
…’s backgroundColor property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeffbailey ! 👍
I'm not 100% sure this will work. See my comment in #294 😊
Also, let's see if we can add a test for this. 😄
2 similar comments
@@ -13,7 +13,12 @@ @implementation IGListCollectionView | |||
|
|||
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout { | |||
if (self = [super initWithFrame:frame collectionViewLayout:layout]) { | |||
self.backgroundColor = [UIColor whiteColor]; | |||
|
|||
UIColor *backgroundAppearanceColor = (UIColor *) [[[self class] appearance] backgroundColor]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can remove this cast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I had to add the cast to avoid a compile error. At first I didn't have the cast when I had the sample project opened, but when I switched to the IGListKit project I got the following:
Incompatible pointer types initializing 'UIColor *__strong' with an expression of type 'CGColorRef _Nullable' (aka 'struct CGColor *')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffbailey -- Ok, I just played around with this and remembered how UIAppearance works.
This looks good to me! 🎉
Boom! Let's land this. |
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Changes in this pull request
Updated IGListCollectionView:initWithFrame:collectionViewLayout constructor to support UIAppearance for the backgroundColor property.
Fixes #294
Pull request checklist