macOS support

[insidegui]

Changes in this pull request

Added support for macOS. The macOS target includes only the core diffing functionality so IGListDiff can be used on macOS apps.

I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some #if os(...)s to the test files.

I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[jessesquires]

Thanks @insidegui ! This looks awesome 🎉

[facebook-github-bot]

@insidegui updated the pull request - view changes

[coveralls]

Coverage remained the same at 94.697% when pulling bef90d3 on insidegui:macOS into c48a39a on Instagram:master.

[jessesquires]

I want to pull this down and test locally, but I think we're good to go. 💯

[rnystrom]

Super super cool. Thanks @insidegui! Going to wait on @jessesquires for confirmation here.

[rnystrom]

@insidegui heads up, looks like there's a rebase issue atm

[insidegui]

Fixed! I also added some comments to make it more clear where the platform-specific and shared headers should go.

[facebook-github-bot]

@insidegui updated the pull request - view changes

[coveralls]

Coverage remained the same at 94.481% when pulling 1f87ccc on insidegui:macOS into 90cf9d5 on Instagram:master.

[jessesquires]

Hey @insidegui -- quick update.

We definitely want this, but I'd like to target 2.x release instead of 2.0. We've been landing a few changes since this was opened and we have a few more. Once this settles down, let's rebase this and then we'll merge after 2.0.

---

I'd like to follow-up with a 2.1 very shortly after 2.0 since this is an additive change.

/cc @rnystrom

[jessesquires]

@insidegui -- Ok, I think master has settled! Do you mind rebasing? 😄

[insidegui]

Squashed and rebased. Fixed Podspec to include NSString and NSNumber categories. I think that's it =)

[facebook-github-bot]

@insidegui updated the pull request - view changes

[coveralls]

Coverage remained the same at 94.597% when pulling 58d4246 on insidegui:macOS into 1c44991 on Instagram:master.

[jessesquires]

Just pulled this down to test and everything is awesome 🎉

Thanks again @insidegui !

[jessesquires]

I've created milestone 2.1.0 to track this and some follow-up work.

We'll get this done immediately after the 2.0.0 release 💯

[jessesquires]

@insidegui - Actually, regarding #270 (the follow-ups), we could do a few of those things here if you want:

1. add the test target with tests
2. update .travis.yml
3. add the macro to simplify the UIKit/Cocoa imports

(For everything else, let's hold off so we can keep this PR small)

If you aren't interested in this stuff, no worries! 😄 We'll pick it up after we merge.

[insidegui]

I'll leave those to you 😄

[rnystrom]

@insidegui @jessesquires how we feeling here? Good to land for 2.1.0?

[jessesquires]

@rnystrom - Yep, I'm still waiting to land. Will do this later today or tomorrow. I want to do my follow-ups (#270) immediately after.

[facebook-github-bot]

@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.