-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS support #235
macOS support #235
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks @insidegui ! This looks awesome 🎉 |
@insidegui updated the pull request - view changes |
I want to pull this down and test locally, but I think we're good to go. 💯 |
Super super cool. Thanks @insidegui! Going to wait on @jessesquires for confirmation here. |
@insidegui heads up, looks like there's a rebase issue atm |
Fixed! I also added some comments to make it more clear where the platform-specific and shared headers should go. |
@insidegui updated the pull request - view changes |
Hey @insidegui -- quick update. We definitely want this, but I'd like to target I'd like to follow-up with a
|
@insidegui -- Ok, I think |
Squashed and rebased. Fixed Podspec to include |
@insidegui updated the pull request - view changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pulled this down to test and everything is awesome 🎉
Thanks again @insidegui !
I've created milestone 2.1.0 to track this and some follow-up work. We'll get this done immediately after the |
@insidegui - Actually, regarding #270 (the follow-ups), we could do a few of those things here if you want:
(For everything else, let's hold off so we can keep this PR small) If you aren't interested in this stuff, no worries! 😄 We'll pick it up after we merge. |
I'll leave those to you 😄 |
@insidegui @jessesquires how we feeling here? Good to land for 2.1.0? |
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Changes in this pull request
Added support for macOS. The macOS target includes only the core diffing functionality so
IGListDiff
can be used on macOS apps.I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some
#if os(...)
s to the test files.I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods.