Created tvOS Example Pack #141

Sherlouk · 2016-10-30T09:43:59Z

Changes in this pull request

Created a new workspace for tvOS examples w/ Cocoapods & dependency on IGListKit
Created a demo chooser across the same lines as the iOS equivalent
Duplicated the 'Nested Adapter' example from iOS pack to the tvOS example
- Uses native navigation to get around, created focus/active states for cells
Updated travis.yml to optionally build tvOS example pack

Note: Not added any imagery/icons/etc due to the much larger & different sizes required - If they're desired then someone with skills will need to provide them!

Closes #138
Relates to #137

Pull request checklist

All tests pass. Demo project builds and runs.
I have reviewed the contributing guide

facebook-github-bot · 2016-10-30T09:47:33Z

@Sherlouk updated the pull request - view changes

coveralls · 2016-10-30T09:51:32Z

Coverage remained the same at 86.482% when pulling e2f042f on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

facebook-github-bot · 2016-10-30T09:56:16Z

@Sherlouk updated the pull request - view changes

facebook-github-bot · 2016-10-30T10:03:20Z

@Sherlouk updated the pull request - view changes

coveralls · 2016-10-30T10:23:51Z

Coverage remained the same at 86.482% when pulling 120244e on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

Sherlouk · 2016-10-30T10:28:25Z

Having a few issues with the travis change, wasn't working locally when I tried but a few retrys later it worked locally.

Would appreciate some help with that!

rnystrom · 2016-11-03T15:08:38Z

@Sherlouk It looks like Travis is timing out from a build issue. You should be able to run this locally:

$ xcodebuild build -workspace Examples-tvOS/IGListKitExamples.xcworkspace -scheme IGListKitExamples -sdk "$TVOS_SDK" -destination "OS=9.0,name=Apple TV 1080p" ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO -verbose

That's the command its timing out on (+ -verbose): https://travis-ci.org/Instagram/IGListKit/jobs/171743818

Also I've literally never built an Apple TV app, so I'm pretty n00b when it comes to that 🙊

jessesquires

Thanks @Sherlouk !

Let's mark all these new classes final, too

jessesquires · 2016-11-03T15:25:31Z

.travis.yml


 script:
 - if [ $POD_LINT == "YES" ]; then
      bundle exec pod lib lint;
  fi


- if [ $BUILD_EXAMPLE == "YES" ]; then
+- if [ $BUILD_IOS_EXAMPLE == "YES" ]; then
      xcodebuild build -workspace Example/IGListKitExamples.xcworkspace -scheme IGListKitExamples -sdk "$SDK" -destination "$DESTINATION" ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO | bundle exec xcpretty -c;


Let's revert these changes. Instead, inside of this if we can check the value of $SDK

Agree, much better idea! Admittedly not my strong point!

jessesquires · 2016-11-03T15:28:49Z

Examples-tvOS/Pods/Manifest.lock

+
+PODFILE CHECKSUM: 4bdfb42d1e7b2b121bf8c83bc300d7d77aa0fc3a
+
+COCOAPODS: 1.0.1


let's use 1.1.1

Left it as default, will change

Sherlouk · 2016-11-03T15:38:37Z

With regards to Travis, definitely not my strong point but will try and get it working (will make the suggested changes first!)

Definitely happy with making things final and updating the cocoapods version.

Are we satisfied with the demo I chose to do/the chooser I implemented?

I'm actually with you @rnystrom I've actually never done tvOS hence why I wanted to do this to try and learn something new :) (Had fun learning how to focus cells and doing all that!)

facebook-github-bot · 2016-11-05T10:22:56Z

@Sherlouk updated the pull request - view changes

Sherlouk · 2016-11-05T10:26:08Z

Travis hasn't run yet, but I haven't changed the build command so I doubt the result will change.

When I ran the build command locally it didn't work at first, it stalled because I had a different build of xcode open than it wanted to use. It was forcing itself to use xcode 8 but I had 8.beta2 open. I closed it, and reran the command and it worked perfectly.

I've updated my local version of cocoapods to 1.1.1, made classes final and made the travis file a bit cleaner as per requests.

coveralls · 2016-11-05T10:33:09Z

Coverage increased (+0.02%) to 86.499% when pulling 5d019e7 on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

coveralls · 2016-11-05T10:33:09Z

Coverage increased (+0.02%) to 86.499% when pulling 5d019e7 on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

Sherlouk · 2016-11-05T10:34:03Z

As much as I'd love to say I fixed it -- I broke the build shell script. 🙈

Working on it

facebook-github-bot · 2016-11-05T10:39:37Z

@Sherlouk updated the pull request - view changes

Sherlouk · 2016-11-05T10:51:40Z

Failed in same place, but no closer to finding the actual issue.

As I mentioned previously working fine when running locally, so let's just ship my machine!

But in all seriousness, any ideas @rnystrom ?

coveralls · 2016-11-05T10:56:00Z

Coverage increased (+0.02%) to 86.499% when pulling f29648a on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

coveralls · 2016-11-05T10:56:01Z

Coverage increased (+0.02%) to 86.499% when pulling f29648a on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

jessesquires · 2016-11-05T15:17:56Z

.travis.yml

+      xcodebuild build -workspace Examples-tvOS/IGListKitExamples.xcworkspace -scheme IGListKitExamples -sdk "$SDK" -destination "$DESTINATION" ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO | bundle exec xcpretty -c;
+  fi
+
+


jessesquires · 2016-11-05T15:19:03Z

@Sherlouk -- are the tvOS example schemes shared?

facebook-github-bot · 2016-11-05T15:22:01Z

@Sherlouk updated the pull request - view changes

Sherlouk · 2016-11-05T15:22:53Z

@jessesquires Yeah, obviously, who would forget to do that? Insane idea!

(oops)

coveralls · 2016-11-05T15:30:06Z

Coverage increased (+0.02%) to 86.499% when pulling 94e5116 on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

coveralls · 2016-11-05T15:30:06Z

Coverage increased (+0.02%) to 86.499% when pulling 94e5116 on Sherlouk:tvOS-example into 9e8ad96 on Instagram:master.

Sherlouk · 2016-11-05T15:30:59Z

That was slightly embarrassing. 😓

Thanks Jesse!

rnystrom · 2016-11-07T14:51:13Z

@Sherlouk what's the reasoning behind another sample project vs adding this all to the existing one?

IMO I'd like to keep the top-level dir as trim as possible (which is becoming tough). Can we not add this to the existing sample project? Maybe I missed something?

Sherlouk · 2016-11-07T15:30:55Z

@rnystrom It originally was all in one project file, but redid it all in a fresh project file as per @jessesquires' comments (#138 (comment))

Edit://
I see a few options here, we leave it as it is and have top level functions for iOS, tvOS and soon macOS. We have a single 'Examples' folder with subdirectories for 'iOS', 'macOS', and 'tvOS'. Or we have one project file with everything in.

I have no real preference, but I do think one project file might get a bit unmanageable over time especially with things like Today/iMessage schemes which only work on iOS etc etc

Sherlouk · 2016-11-13T16:29:31Z

@rnystrom @jessesquires

Any note on what I need to do to move this forward?

jessesquires · 2016-11-14T07:06:45Z

@rnystrom -- Yeah, I think we should have a separate tvOS example project.

Let's keep directories how they are for this PR and follow up after.

Here's what I propose:

|-- Examples/
    |-- Examples-iOS/
    |-- Examples-tvOS/

jessesquires · 2016-11-15T23:40:57Z

I think we're good to go here.

@rnystrom -- Any other review comments?

@Sherlouk -- Sorry for the delay here! Looks like there's one conflict in CHANGELOG.md. Sorry about that. Should be easy to fix though.

Follow up task to clean up directories: #202

# Conflicts: # CHANGELOG.md

facebook-github-bot · 2016-11-15T23:44:57Z

@Sherlouk updated the pull request - view changes

Sherlouk · 2016-11-15T23:45:42Z

@jessesquires Not a problem, was waiting for everybody to be happy before fixing it as other PRs kept making it conflict!

Should all work now 🙏

rnystrom · 2016-11-15T23:56:17Z

Let's land it! 🚀 🚀 🚀

coveralls · 2016-11-16T03:54:08Z

Coverage remained the same at 91.441% when pulling 61e8eab on Sherlouk:tvOS-example into 204f7d5 on Instagram:master.

coveralls · 2016-11-16T03:54:08Z

Coverage remained the same at 91.441% when pulling 61e8eab on Sherlouk:tvOS-example into 204f7d5 on Instagram:master.

facebook-github-bot · 2016-11-16T15:40:01Z

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jessesquires and others added 5 commits October 29, 2016 11:19

Add tvOS support. Close Instagram#118

15ca883

project - sort by name

ae62caf

update README

08cef3a

Created tvOS workspace with Pods

e38a67d

Added tvOS nested adapter example

4843b99

Sherlouk changed the title ~~Tv os example~~ Created tvOS Example Pack Oct 30, 2016

Added changelog entry for tvOS example pack

e2f042f

facebook-github-bot added the CLA Signed label Oct 30, 2016

Updated travis.yml to build tvOS example

0eacfd7

Fixed conflicts when pulling in upstream/master

120244e

jessesquires suggested changes Nov 3, 2016

View reviewed changes

Sherlock added 3 commits November 5, 2016 10:08

Made all classes final in tvOS pack

e16cf04

Updated cocoapods to 1.1.1

bfa2dda

Updated travis file

5d019e7

Fix travis run script

f29648a

jessesquires reviewed Nov 5, 2016

View reviewed changes

Shared examples scheme (tvOS)

94e5116

jessesquires approved these changes Nov 15, 2016

View reviewed changes

jessesquires mentioned this pull request Nov 15, 2016

Fixup Examples directory #202

Closed

Merge remote-tracking branch 'upstream/master' into tvOS-example

61e8eab

# Conflicts: # CHANGELOG.md

facebook-github-bot closed this in 19280d2 Nov 16, 2016

jessesquires added this to the 2.0.0 milestone Nov 16, 2016

Sherlouk deleted the tvOS-example branch December 30, 2016 14:09


		PODFILE CHECKSUM: 4bdfb42d1e7b2b121bf8c83bc300d7d77aa0fc3a

		COCOAPODS: 1.0.1

		xcodebuild build -workspace Examples-tvOS/IGListKitExamples.xcworkspace -scheme IGListKitExamples -sdk "$SDK" -destination "$DESTINATION" ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO \| bundle exec xcpretty -c;
		fi

Created tvOS Example Pack #141

Created tvOS Example Pack #141

Conversation

Sherlouk commented Oct 30, 2016 • edited Loading

Changes in this pull request

Pull request checklist

facebook-github-bot commented Oct 30, 2016

coveralls commented Oct 30, 2016 • edited Loading

facebook-github-bot commented Oct 30, 2016

facebook-github-bot commented Oct 30, 2016

coveralls commented Oct 30, 2016

Sherlouk commented Oct 30, 2016

rnystrom commented Nov 3, 2016 • edited Loading

jessesquires left a comment

Choose a reason for hiding this comment

jessesquires Nov 3, 2016

Choose a reason for hiding this comment

Sherlouk Nov 3, 2016

Choose a reason for hiding this comment

jessesquires Nov 3, 2016

Choose a reason for hiding this comment

Sherlouk Nov 3, 2016

Choose a reason for hiding this comment

Sherlouk commented Nov 3, 2016

facebook-github-bot commented Nov 5, 2016

Sherlouk commented Nov 5, 2016

coveralls commented Nov 5, 2016

coveralls commented Nov 5, 2016

Sherlouk commented Nov 5, 2016

facebook-github-bot commented Nov 5, 2016

Sherlouk commented Nov 5, 2016

coveralls commented Nov 5, 2016

coveralls commented Nov 5, 2016

jessesquires Nov 5, 2016

Choose a reason for hiding this comment

jessesquires commented Nov 5, 2016

facebook-github-bot commented Nov 5, 2016

Sherlouk commented Nov 5, 2016

coveralls commented Nov 5, 2016

coveralls commented Nov 5, 2016

Sherlouk commented Nov 5, 2016 • edited Loading

rnystrom commented Nov 7, 2016

Sherlouk commented Nov 7, 2016 • edited Loading

Sherlouk commented Nov 13, 2016

jessesquires commented Nov 14, 2016

jessesquires commented Nov 15, 2016

facebook-github-bot commented Nov 15, 2016

Sherlouk commented Nov 15, 2016

rnystrom commented Nov 15, 2016

coveralls commented Nov 16, 2016

coveralls commented Nov 16, 2016

facebook-github-bot commented Nov 16, 2016

Sherlouk commented Oct 30, 2016 •

edited

Loading

coveralls commented Oct 30, 2016 •

edited

Loading

rnystrom commented Nov 3, 2016 •

edited

Loading

Sherlouk commented Nov 5, 2016 •

edited

Loading

Sherlouk commented Nov 7, 2016 •

edited

Loading